[bitnami/neo4j] Add chart by migruiz4 · Pull Request #27616 · bitnami/charts

migruiz4 · 2024-07-01T14:59:08Z

Description of the change

Adds the new chart 'bitnami/neo4j' to the catalog.

This PR is currently in draft, the following items are still pending:

Release and use bitnami/neo4j image (currently using a custom image)

Checklist

Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Signed-off-by: Miguel Ruiz <miruiz@vmware.com>

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>

Signed-off-by: Miguel Ruiz <miruiz@vmware.com>

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>

Signed-off-by: Miguel Ruiz <miruiz@vmware.com>

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>

Signed-off-by: Miguel Ruiz <miruiz@vmware.com>

jotamartos · 2024-07-03T07:39:32Z

LGTM! I know you are still making changes and can review them when needed but the current code looks fine 👍

Signed-off-by: Miguel Ruiz <miruiz@vmware.com>

fmulero

Brilliant!! thanks a lot @migruiz4

Everything looks great, I have only some improvements.

NOTE: Recent charts (for instance: seaweed) can use cert manager for automated certificates. I think is worth to give it a glance.

Signed-off-by: Miguel Ruiz <miruiz@vmware.com>

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>

Signed-off-by: Miguel Ruiz <miruiz@vmware.com>

fmulero

LGTM

rafariossaa

LGTM

* [bitnami/neo4j] Add chart Signed-off-by: Miguel Ruiz <miruiz@vmware.com> * Add support for readOnlyRootFilesystem, use development image Signed-off-by: Miguel Ruiz <miruiz@vmware.com> * Remove serviceMonitor Signed-off-by: Miguel Ruiz <miruiz@vmware.com> * Add VIB tests and image improvements Signed-off-by: Miguel Ruiz <miruiz@vmware.com> * Add neo4j host Signed-off-by: Miguel Ruiz <miruiz@vmware.com> * Update chart Signed-off-by: Miguel Ruiz <miruiz@vmware.com> * Fix values metadata Signed-off-by: Miguel Ruiz <miruiz@vmware.com> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Fix test inputs Signed-off-by: Miguel Ruiz <miruiz@vmware.com> * Add TLS support Signed-off-by: Miguel Ruiz <miruiz@vmware.com> * Change readiness Signed-off-by: Miguel Ruiz <miruiz@vmware.com> * Update README metadata Signed-off-by: Miguel Ruiz <miruiz@vmware.com> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Update test service ports Signed-off-by: Miguel Ruiz <miruiz@vmware.com> * Add goss https test Signed-off-by: Miguel Ruiz <miruiz@vmware.com> * Fix goss vars file Signed-off-by: Miguel Ruiz <miruiz@vmware.com> * Update dev image Signed-off-by: Miguel Ruiz <miruiz@vmware.com> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Increase timeout Signed-off-by: Miguel Ruiz <miruiz@vmware.com> * Change bolt port Signed-off-by: Miguel Ruiz <miruiz@vmware.com> * Use bitnami/neo4j:5.20.0-debian-12-r2 Signed-off-by: Miguel Ruiz <miruiz@vmware.com> * Modify TLS secrets Signed-off-by: Miguel Ruiz <miruiz@vmware.com> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Add ingress-tls-secret.yaml Signed-off-by: Miguel Ruiz <miruiz@vmware.com> --------- Signed-off-by: Miguel Ruiz <miruiz@vmware.com> Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> Co-authored-by: Bitnami Containers <bitnami-bot@vmware.com>

Miguel Ruiz added 2 commits June 27, 2024 12:32

[bitnami/neo4j] Add chart

52d2ca6

Signed-off-by: Miguel Ruiz <miruiz@vmware.com>

Add support for readOnlyRootFilesystem, use development image

fe64630

Signed-off-by: Miguel Ruiz <miruiz@vmware.com>

github-actions Bot added the neo4j label Jul 1, 2024

bitnami-bot added the verify Execute verification workflow for these changes label Jul 1, 2024

github-actions Bot added the bitnami label Jul 1, 2024

github-actions Bot assigned alemorcuq Jul 1, 2024

github-actions Bot requested a review from alemorcuq July 1, 2024 14:59

migruiz4 requested review from fmulero, javsalgar and jotamartos and removed request for alemorcuq July 1, 2024 15:01

migruiz4 assigned javsalgar, jotamartos and fmulero and unassigned alemorcuq Jul 1, 2024

Remove serviceMonitor

977f4b6

Signed-off-by: Miguel Ruiz <miruiz@vmware.com>

carrodher added the new-product Request new product to be added into the catalog label Jul 1, 2024

carrodher unassigned javsalgar Jul 1, 2024

carrodher removed the request for review from javsalgar July 1, 2024 15:04

Miguel Ruiz and others added 7 commits July 2, 2024 14:09

Add VIB tests and image improvements

cc9dd59

Signed-off-by: Miguel Ruiz <miruiz@vmware.com>

Add neo4j host

3fb48db

Signed-off-by: Miguel Ruiz <miruiz@vmware.com>

Update chart

76b71e8

Signed-off-by: Miguel Ruiz <miruiz@vmware.com>

Fix values metadata

d07f9e1

Signed-off-by: Miguel Ruiz <miruiz@vmware.com>

Update CHANGELOG.md

81eed71

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>

Update README.md with readme-generator-for-helm

22d1a64

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>

Fix test inputs

65bafb6

Signed-off-by: Miguel Ruiz <miruiz@vmware.com>

migruiz4 force-pushed the neo4j-chart branch from fdf1b1e to 65bafb6 Compare July 2, 2024 14:10

Add TLS support

1d628a8

Signed-off-by: Miguel Ruiz <miruiz@vmware.com>

migruiz4 marked this pull request as ready for review July 2, 2024 15:09

Change readiness

c6c0b0f

Signed-off-by: Miguel Ruiz <miruiz@vmware.com>

Miguel Ruiz and others added 8 commits July 2, 2024 17:13

Update README metadata

b601d84

Signed-off-by: Miguel Ruiz <miruiz@vmware.com>

Update README.md with readme-generator-for-helm

f84b0d4

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>

Update test service ports

c0c091f

Signed-off-by: Miguel Ruiz <miruiz@vmware.com>

Add goss https test

10dd731

Signed-off-by: Miguel Ruiz <miruiz@vmware.com>

Fix goss vars file

321eb71

Signed-off-by: Miguel Ruiz <miruiz@vmware.com>

Update dev image

22a0ae1

Signed-off-by: Miguel Ruiz <miruiz@vmware.com>

Update CHANGELOG.md

48943a1

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>

Increase timeout

e108aef

Signed-off-by: Miguel Ruiz <miruiz@vmware.com>

jotamartos previously approved these changes Jul 3, 2024

View reviewed changes

Change bolt port

a787e69

Signed-off-by: Miguel Ruiz <miruiz@vmware.com>

migruiz4 dismissed jotamartos’s stale review via a787e69 July 3, 2024 08:42

fmulero reviewed Jul 3, 2024

View reviewed changes

Comment thread bitnami/neo4j/templates/statefulset.yaml

Comment thread bitnami/neo4j/templates/tls-secret.yaml Outdated

Miguel Ruiz and others added 4 commits July 3, 2024 14:49

Use bitnami/neo4j:5.20.0-debian-12-r2

7f7639a

Signed-off-by: Miguel Ruiz <miruiz@vmware.com>

Modify TLS secrets

ad17fa6

Signed-off-by: Miguel Ruiz <miruiz@vmware.com>

Update CHANGELOG.md

9869cc9

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>

Add ingress-tls-secret.yaml

c75755c

Signed-off-by: Miguel Ruiz <miruiz@vmware.com>

fmulero approved these changes Jul 4, 2024

View reviewed changes

carrodher requested a review from rafariossaa July 4, 2024 11:08

carrodher assigned rafariossaa Jul 4, 2024

migruiz4 merged commit e74b9ca into main Jul 4, 2024

migruiz4 deleted the neo4j-chart branch July 4, 2024 11:49

github-actions Bot added the solved label Jul 4, 2024

rafariossaa reviewed Jul 4, 2024

View reviewed changes

Navigation Menu

Uh oh!

[bitnami/neo4j] Add chart - #27616

[bitnami/neo4j] Add chart#27616
migruiz4 merged 25 commits into
mainfrom
neo4j-chart

migruiz4 commented Jul 1, 2024 •

edited

Loading

Uh oh!

jotamartos commented Jul 3, 2024 •

edited

Loading

Uh oh!

fmulero left a comment

Uh oh!

Uh oh!

Uh oh!

fmulero left a comment

Uh oh!

rafariossaa left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

migruiz4 commented Jul 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of the change

Checklist

Uh oh!

jotamartos commented Jul 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fmulero left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

fmulero left a comment

Choose a reason for hiding this comment

Uh oh!

rafariossaa left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

migruiz4 commented Jul 1, 2024 •

edited

Loading

jotamartos commented Jul 3, 2024 •

edited

Loading