Merged
Conversation
Contributor
kleetus
commented
Sep 4, 2015
kleetus
commented
- If the reindex option is set in bitcoin.conf, then when start is called and onBlocksReady's callback is fired:
- start's callback will not be fired until the reindex takes place.
- along the way the sync percentage is display once per second
- If the reindex option is set in bitcoin.conf, then when start is called and onBlocksReady's callback is fired: - start's callback will not be fired until the reindex takes place. - along the way the sync percentage is display once per second
Contributor
There was a problem hiding this comment.
Could be better to mention that the reindex flag will start the index from beginning every time the node is started, so it should be removed after the reindex has be initiated.
Contributor
|
LGTM |
Contributor
|
I did notice when testing that since all the services do not start, shutting down will error, however that is fixed with: #199 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.