Merged
Conversation
braydonf
changed the title
braydonf
force-pushed
the
start-error
branch
from
b9d688c to
71de808
Compare
braydonf
changed the title
- A Node will shutdown if there is an error starting a service as it would lead to cascading errors. - `node.start()` needs to be called, and nolonger is called automatically when the instance is created. - A service will only be added to node.services after it's started - Stopping services that are not started will gracefully continue. - Logging sync status of db will only apply if the service is started. - Debug log about a service without a route will always include the service name
braydonf
force-pushed
the
start-error
branch
from
71de808 to
60af867
Compare
Merged
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node.start()needs to be called, and nolonger is called automatically when the instance is created.