feat(Alert): cascade color to inner Avatar#29
Open
IgorShevchik wants to merge 1 commit into
Open
Conversation
This was referenced May 11, 2026
IgorShevchik
force-pushed
the
feat/alert-avatar-color
branch
from
6c9f2f5 to
c13b748
Compare
The existing top-level `color` prop now also tints the inner `B24Avatar` by default. An explicit `avatar.color` still wins, since `v-bind="props.avatar"` is applied after `:color="props.color"`. `Alert.variants.color` is a superset of `AvatarProps['color']` (legacy `'default'` etc.), so the binding casts to the Avatar color type at the template site. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
IgorShevchik
force-pushed
the
feat/alert-avatar-color
branch
from
c13b748 to
d2502cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
colorprop onB24Alertnow also tints the innerB24Avatarby default.avatar.colorstill wins, sincev-bind="props.avatar"is applied after:color="props.color".Alert.variants.coloris a superset ofAvatarProps['color'](it includes legacy entries like'default'), so the binding casts to the Avatar color type at the template site — no API change, no theme change.Follow-up to #24 (Avatar/AvatarGroup
color), #27 (User color), #28 (ChatMessage color).Test plan
pnpm run lintpassespnpm run typecheckpasses (root + docs + both playgrounds)pnpm run testpasses — newrenders with color and avatar correctlysnapshot witnesses the cascade (style-filled-successon the Avatar root when Alert isair-primary-success)avatar.coloroverrides the cascade (set:avatar="{ src: '...', color: 'air-tertiary-accent' }"whilecolor="air-primary-alert"onB24Alert— avatar should be tertiary-accent)🤖 Generated with Claude Code