feat(Timeline): cascade color to indicator Avatar#31
Open
IgorShevchik wants to merge 1 commit into
Open
Conversation
This was referenced May 11, 2026
IgorShevchik
force-pushed
the
feat/timeline-avatar-color
branch
from
2788cda to
d8679cd
Compare
The existing top-level `color` prop now also tints the indicator `B24Avatar` of every item. An explicit `item.avatar.color` still wins, since `v-bind="item.avatar"` is applied after `:color="props.color"`. `Timeline.variants.color` is a strict subset of `AvatarProps['color']` (only `air-primary*`), so the binding casts to the Avatar color type at the template site. Existing `with air-primary color` snapshot is updated to reflect the new indicator style. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
IgorShevchik
force-pushed
the
feat/timeline-avatar-color
branch
from
d8679cd to
d556d22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
colorprop onB24Timelinenow also tints the indicatorB24Avatarof every item.item.avatar.colorstill wins, sincev-bind="item.avatar"is applied after:color="props.color".Timeline.variants.coloris a strict subset ofAvatarProps['color'](onlyair-primary*), so the binding casts to the Avatar color type at the template site. No API change, no theme change.renders with air-primary color correctlysnapshot is updated: the indicator span now rendersstyle-filledinstead ofstyle-outline-no-accent.renders with color and avatar correctlysnapshot witnesses the cascade with avatar items.Follow-up to #24 (Avatar/AvatarGroup
color), #27 (User), #28 (ChatMessage), #29 (Alert), #30 (Toast).Test plan
pnpm run lintpassespnpm run typecheckpassespnpm run testpasses — Timeline snapshots witness the cascadeitem.avatar.coloroverrides the cascade🤖 Generated with Claude Code