feat(CommandPalette): add item.color forwarded to leading Avatar#34
Open
IgorShevchik wants to merge 1 commit into
Open
feat(CommandPalette): add item.color forwarded to leading Avatar#34IgorShevchik wants to merge 1 commit into
IgorShevchik wants to merge 1 commit into
Conversation
3 tasks
IgorShevchik
force-pushed
the
feat/command-palette-avatar-color
branch
from
d3d76e8 to
559c302
Compare
Adds `color?: AvatarProps['color']` to `CommandPaletteItem` and forwards it as the default `color` to the item's leading `B24Avatar`. Explicit `item.avatar.color` still wins, since `v-bind="item.avatar"` is applied after `:color="item.color"`. No host-level color is introduced — the new prop only tints the inner Avatar. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
IgorShevchik
force-pushed
the
feat/command-palette-avatar-color
branch
from
559c302 to
6171a3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
color?: AvatarProps['color']toCommandPaletteItem.colorto the item's leadingB24Avatar. Explicititem.avatar.colorstill wins, sincev-bind="item.avatar"is applied after:color="item.color".src/theme/command-palette.tsis untouched. The new prop only tints the inner Avatar.Follow-up to #24 (Avatar/AvatarGroup
color), #27 (User), #28 (ChatMessage), #29 (Alert), #30 (Toast), #31 (Timeline), #32 (NavigationMenu), #33 (Tabs).Test plan
pnpm run lint/pnpm run typecheck/pnpm run testpassrenders with item color correctlysnapshot witnesses the cascade (item 1 →style-filledforair-primary, item 2 →style-filled-successforair-primary-success)colortints the avataritem.avatar.coloroverrides the cascade🤖 Generated with Claude Code