Skip to content

[PM-33046] Remove legacy cache DI registration in Events#7958

Merged
JimmyVo16 merged 1 commit into
mainfrom
ac/pm-33046/events-di
Jul 13, 2026
Merged

[PM-33046] Remove legacy cache DI registration in Events#7958
JimmyVo16 merged 1 commit into
mainfrom
ac/pm-33046/events-di

Conversation

@JimmyVo16

@JimmyVo16 JimmyVo16 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

🎯 Objective

Part of removing the legacy in-memory application cache system (PM-33046).

Ticket: https://bitwarden.atlassian.net/browse/PM-33046

⚠️ Merge order (important)

This is one atomic removal split into 4 stacked-by-dependency PRs, all based on main. To keep main compiling and runtime-safe, they must merge in this order:

  1. events-di (Data Insights & Reporting) — remove DI consumer in Events
  2. core-services (Core / platform) — delete cache service impls + SharedWeb DI
  3. admin-console-repos (Admin Console) — delete cache interface + GetManyAbilitiesAsync repo methods
  4. dbops-drop-procs (DB Ops) — drop the stored procedures the Dapper code called

👉 This PR is step 1 of 4.

📋 Code Changes

  • src/Events/Startup.cs — remove the in-memory app cache service registration

Part of removing the legacy in-memory application cache system.
Drops the IVCurrentInMemoryApplicationCacheService DI registration from
the Events Startup.
@JimmyVo16 JimmyVo16 self-assigned this Jul 10, 2026
@JimmyVo16 JimmyVo16 added ai-review Request a Claude code review t:tech-debt Change Type - Tech debt labels Jul 10, 2026
@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the removal of the IVCurrentInMemoryApplicationCacheService DI registration from src/Events/Startup.cs (step 1 of 4 in PM-33046). Confirmed no constructor consumers of the interface exist anywhere in the codebase, so removing the registration carries no DI-resolution risk for the Events app. The usingServiceBusAppCache variable remains legitimately used for the ApplicationCacheHostedService registration, and the replacement ability-cache services (AddOrganizationAbilityCache/AddProviderAbilityCache) are already registered.

Code Review Details

No findings. Clean, minimal tech-debt change with clear merge ordering documented across the stacked PR set.

@JimmyVo16 JimmyVo16 merged commit c9460cc into main Jul 13, 2026
57 of 61 checks passed
@JimmyVo16 JimmyVo16 deleted the ac/pm-33046/events-di branch July 13, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review t:tech-debt Change Type - Tech debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants