[PM-33046] Remove legacy in-memory application cache services#7959
Conversation
Part of removing the legacy in-memory application cache system. Deletes InMemoryApplicationCacheService and InMemoryServiceBusApplicationCacheService, their tests, and the SharedWeb DI registration.
5d293f4 to
7d91d08
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7959 +/- ##
==========================================
+ Coverage 61.60% 61.67% +0.06%
==========================================
Files 2256 2254 -2
Lines 99392 99267 -125
Branches 8983 8978 -5
==========================================
- Hits 61232 61220 -12
+ Misses 36005 35893 -112
+ Partials 2155 2154 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE Reviewed the removal of the legacy in-memory application cache services ( Verified that both deleted implementation classes have zero remaining references, the removed DI block was the only registration path (its consumers were migrated in step 1), and the replacement Code Review DetailsNo findings. Clean, well-scoped tech-debt removal with clearly documented stacked-merge ordering. |
🎯 Objective
Part of removing the legacy in-memory application cache system (PM-33046).
Ticket: https://bitwarden.atlassian.net/browse/PM-33046
This is one atomic removal split into 4 stacked-by-dependency PRs, all based on
main. To keepmaincompiling and runtime-safe, they must merge in this order:events-di(Data Insights & Reporting) — remove DI consumer in Eventscore-services(Core / platform) — delete cache service impls + SharedWeb DIadmin-console-repos(Admin Console) — delete cache interface +GetManyAbilitiesAsyncrepo methodsdbops-drop-procs(DB Ops) — drop the stored procedures the Dapper code called👉 This PR is step 2 of 4. Do not merge before the step above it.
📋 Code Changes
src/Core/Services/Implementations/InMemoryApplicationCacheService.cs— deletedsrc/Core/Services/Implementations/InMemoryServiceBusApplicationCacheService.cs— deletedsrc/SharedWeb/Utilities/ServiceCollectionExtensions.cs— remove DI registrationtest/Core.Test/Services/InMemoryApplicationCacheServiceTests.cs— deletedtest/Core.Test/Services/InMemoryServiceBusApplicationCacheServiceTests.cs— deleted