Skip to content

[PM-33046] Remove legacy in-memory application cache services#7959

Merged
JimmyVo16 merged 1 commit into
mainfrom
ac/pm-33046/core-services
Jul 13, 2026
Merged

[PM-33046] Remove legacy in-memory application cache services#7959
JimmyVo16 merged 1 commit into
mainfrom
ac/pm-33046/core-services

Conversation

@JimmyVo16

@JimmyVo16 JimmyVo16 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

🎯 Objective

Part of removing the legacy in-memory application cache system (PM-33046).

Ticket: https://bitwarden.atlassian.net/browse/PM-33046

⚠️ Merge order (important)

This is one atomic removal split into 4 stacked-by-dependency PRs, all based on main. To keep main compiling and runtime-safe, they must merge in this order:

  1. events-di (Data Insights & Reporting) — remove DI consumer in Events
  2. core-services (Core / platform) — delete cache service impls + SharedWeb DI
  3. admin-console-repos (Admin Console) — delete cache interface + GetManyAbilitiesAsync repo methods
  4. dbops-drop-procs (DB Ops) — drop the stored procedures the Dapper code called

👉 This PR is step 2 of 4. Do not merge before the step above it.

📋 Code Changes

  • src/Core/Services/Implementations/InMemoryApplicationCacheService.cs — deleted
  • src/Core/Services/Implementations/InMemoryServiceBusApplicationCacheService.cs — deleted
  • src/SharedWeb/Utilities/ServiceCollectionExtensions.cs — remove DI registration
  • test/Core.Test/Services/InMemoryApplicationCacheServiceTests.cs — deleted
  • test/Core.Test/Services/InMemoryServiceBusApplicationCacheServiceTests.cs — deleted

Part of removing the legacy in-memory application cache system.
Deletes InMemoryApplicationCacheService and
InMemoryServiceBusApplicationCacheService, their tests, and the SharedWeb
DI registration.
@JimmyVo16 JimmyVo16 force-pushed the ac/pm-33046/core-services branch from 5d293f4 to 7d91d08 Compare July 13, 2026 17:24
@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.67%. Comparing base (c9460cc) to head (7d91d08).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7959      +/-   ##
==========================================
+ Coverage   61.60%   61.67%   +0.06%     
==========================================
  Files        2256     2254       -2     
  Lines       99392    99267     -125     
  Branches     8983     8978       -5     
==========================================
- Hits        61232    61220      -12     
+ Misses      36005    35893     -112     
+ Partials     2155     2154       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JimmyVo16 JimmyVo16 self-assigned this Jul 13, 2026
@JimmyVo16 JimmyVo16 added ai-review Request a Claude code review t:tech-debt Change Type - Tech debt labels Jul 13, 2026
@JimmyVo16 JimmyVo16 marked this pull request as ready for review July 13, 2026 18:39
@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the removal of the legacy in-memory application cache services (InMemoryApplicationCacheService, InMemoryServiceBusApplicationCacheService), their SharedWeb DI registration, and the corresponding placeholder tests. This is step 2 of a 4-PR stacked removal for PM-33046.

Verified that both deleted implementation classes have zero remaining references, the removed DI block was the only registration path (its consumers were migrated in step 1), and the replacement AddOrganizationAbilityCache / AddProviderAbilityCache registrations remain in place. The now-orphaned IVCurrentInMemoryApplicationCacheService interface is intentionally deleted in step 3 per the documented merge order.

Code Review Details

No findings. Clean, well-scoped tech-debt removal with clearly documented stacked-merge ordering.

@JimmyVo16 JimmyVo16 requested a review from jrmccannon July 13, 2026 18:40
@JimmyVo16 JimmyVo16 merged commit 264cda5 into main Jul 13, 2026
51 of 56 checks passed
@JimmyVo16 JimmyVo16 deleted the ac/pm-33046/core-services branch July 13, 2026 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review t:tech-debt Change Type - Tech debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants