fix: match private-module org casing to lowercase blanketops rename - #85
Merged
Conversation
go.mod now imports github.com/blanketops/* (lowercase), but Containerfile, melange.yaml, and several CI workflows still set GOPRIVATE/GONOSUMDB and git insteadOf rewrites against the old capitalized BlanketOps/* org. Since GOPRIVATE globs and insteadOf are literal case-sensitive matches, private module downloads fell through to anonymous HTTPS and failed (docker build-push-action run on main: "could not read Username for 'https://github.com': terminal prompts disabled").
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
go.modimports were renamed to lowercasegithub.com/blanketops/*, butContainerfile,melange.yaml, and five GitHub Actions workflows (ci.yaml,gosec.yml,vulnscan.yml,ko.yml,apko.yml) still setGOPRIVATE/GONOSUMDBandgit config ... insteadOfrules against the old capitalizedBlanketOps/*org.GOPRIVATEglob matching andinsteadOfURL rewriting are both case-sensitive literal matches, so the lowercase module path never matched,go mod downloadfell through to anonymous HTTPS, and failed against the private repo:maindocker build-push-action run building tagmain.)release.yml.Test plan
grep -rn "github.com/BlanketOps"across workflows/build files returns no hitsgo mod downloadresolves private modules