fix: switch private-module auth to GH_PAT, fix remaining GHCR casing - #89
Merged
Conversation
…epo paths SSH_PRIVATE_KEY can never authenticate: no SSH keys are registered on any relevant GitHub account (only GPG keys, which sign commits/tags but don't authenticate git operations), so builds using it fail with "Permission denied (publickey)". Switch Containerfile and image.yml/ko.yml to the same GH_PAT-over-HTTPS pattern already working in ci.yaml/gosec.yml/vulnscan.yml/melange.yaml. The Containerfile reads the PAT via a BuildKit secret mount so it never persists in an image layer. Also lowercase the remaining ghcr.io/BlanketOps/* IMAGE_REPO references (ko.yml, vulnscan.yml, apko.yml, release.yml, image.yml comments) missed in the prior org-casing fix — ko.yml's was live-broken: "repository can only contain the characters `abcdefghijklmnopqrstuvwxyz0123456789_-./`".
Under the blanketops/ org namespace, "blanketops-environments-controller" duplicates the org name. Correct GHCR path is ghcr.io/blanketops/environments-controller, matching how GHCR packages are conventionally named after the repo. Docker Hub's path (docker.io/nkanyezisolutions/blanketops-environments-controller) is untouched — no org-name collision there since it's a personal namespace.
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SSH_PRIVATE_KEYcan never authenticate: no SSH keys are registered on any relevant GitHub account (only GPG keys, which sign commits/tags but don't authenticate git operations). Builds using it fail withgit@github.com: Permission denied (publickey).Containerfile(image.yml's build) andko.ymlfrom SSH-based git auth toGH_PAT-over-HTTPS — the same pattern already working inci.yaml/gosec.yml/vulnscan.yml/melange.yaml.GH_PATis passed into the Docker build as a BuildKit secret (--secret id=gh_pat) so it's never written into an image layer.ghcr.io/BlanketOps/*(capital-case)IMAGE_REPOreferences missed by the earlier org-rename PR (fix: match private-module org casing to lowercase blanketops rename #85) —ko.yml's was live-broken:Test plan
docker buildx build --secret id=gh_pat,env=GH_TOKEN -f Containerfileagainst a real PAT confirmedgo mod downloadresolves the privateblanketops/environments,environments-apimodules over HTTPSgrep -rn "BlanketOps"(capital) across workflows/Containerfile returns no functional hitsimage.yml/ko.ymlCI runs green end-to-end (push-triggered, will confirm on merge)