[legacy-framework] (meta) Integrate our new next.js fork into the monorepo at ./nextjs#2079
Merged
[legacy-framework] (meta) Integrate our new next.js fork into the monorepo at ./nextjs#2079
Conversation
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
Contributor
|
Size Change: 0 B Total Size: 230 kB ℹ️ View Unchanged
|
|
Should eslint, prettier, and other tools ignore ./nextjs (at least for now)? |
Member
Author
Prettier isn't ignoring it because it uses the next.js prettier config. eslint is currently ignoring nextjs because it doen't work yet. I'll enable it in another PR (so code inside nextjs uses their eslint config). |
itsdillon
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starts work discussed in #1990
What are the changes and their implications?
We now have an official fork of next.js at https://github.com/blitz-js/next.js
This PR integrates that fork into our monorepo using https://github.com/ingydotnet/git-subrepo which is like git submodules or git subtrees but better.
Git subrepo enables a really nice experience for working on our next js fork right here in our monorepo like the rest of our packages. From a contributor perspective, you don't even need to know that the
nextjsfolder is synced to another repo. You just change files like normal.Process for syncing our fork:
yarn push-nextjsscript which pushes changes from here to https://github.com/blitz-js/next.jsgit fetch upstreamandget merge upstream/canaryand push changesyarn pull-nextjsinside the monorepoThis PR only adds the fork in
nextjsfolder, it doesn't change anything about the fork or change existing blitz code to use the fork.