[legacy-framework] Add spinner for Prettier formatting during 'blitz new'#680
Merged
flybayer merged 1 commit intoblitz-js:canaryfrom Jun 14, 2020
fnoah:canary
Merged
[legacy-framework] Add spinner for Prettier formatting during 'blitz new'#680flybayer merged 1 commit intoblitz-js:canaryfrom fnoah:canary
flybayer merged 1 commit intoblitz-js:canaryfrom
fnoah:canary
Conversation
Zeko369
approved these changes
Jun 13, 2020
Collaborator
Zeko369
left a comment
Zeko369
left a comment
There was a problem hiding this comment.
I'd keep the current Error message
Member
|
@fnoah awesome this looks perfect! Thank you so much! @all-contributors add @fnoah for code |
|
I've put up a pull request to add @fnoah! 🎉 |
flybayer
changed the title
itsdillon
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #672
What are the changes and their implications?
Added a new spinner for prettier formatting on
blitz new. I also removed the error that was previously thrown which prevented theYour new Blitz app is ready! Next steps:message from appearing. I think it makes sense to still show this message since a prettier failure doesn't prevent the app from running.Example of a successful run:
I used the error message copy which @flybayer suggested in the issue. I wasn't sure which styling to use for the error message (since it's an error, but nothing fatal). The current commit uses the first one of the following examples, but I'm interested in what others think is best.
Checklist