Skip to content

[legacy-framework] Fix missing useParam import in edit.tsx page template#684

Merged
aem merged 1 commit intoblitz-js:canaryfrom
donni106:add-missing-useParam-for-edit
Jun 15, 2020
Merged

[legacy-framework] Fix missing useParam import in edit.tsx page template#684
aem merged 1 commit intoblitz-js:canaryfrom
donni106:add-missing-useParam-for-edit

Conversation

@donni106
Copy link

What are the changes and their implications?

  • added useParam from blitz, which was missing and visiting
    edit pages for created models failed

Checklist

  • Tests added for changes
  • PR submitted to blitzjs.com for any user facing changes

- added `useParam` from blitz, which was missing and visiting
  edit pages for created models failed
@donni106 donni106 requested a review from aem as a code owner June 15, 2020 00:32
Copy link
Collaborator

@aem aem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch, thanks for jumping on this!

@aem aem merged commit f0573ac into blitz-js:canary Jun 15, 2020
@aem aem changed the title Add missing useParam import in edit templates Fix missing useParam import in edit.tsx page template Jun 15, 2020
@flybayer
Copy link
Member

@all-contributors add @donni106 for code

@allcontributors
Copy link

@flybayer

I've put up a pull request to add @donni106! 🎉

flybayer pushed a commit that referenced this pull request Jun 15, 2020
(patch)
- added `useParam` from blitz, which was missing and visiting
  edit pages for created models failed
@itsdillon itsdillon changed the title Fix missing useParam import in edit.tsx page template [legacy-framework] Fix missing useParam import in edit.tsx page template Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants