Skip to content

[legacy-framework] Fix issue with using non-page files inside pages folders#733

Merged
flybayer merged 4 commits intocanaryfrom
415-non-js-pages
Jul 8, 2020
Merged

[legacy-framework] Fix issue with using non-page files inside pages folders#733
flybayer merged 4 commits intocanaryfrom
415-non-js-pages

Conversation

@ryardley
Copy link
Collaborator

@ryardley ryardley commented Jul 8, 2020

Closes: blitz-js/legacy-framework#470

What are the changes and their implications?

  • Only copy typescript/javascript files to the pages folder - leave other extensions where they are.
  • Allow imports to be relative transformed when import does not have an import specifier.

Checklist

  • Tests added for changes
  • PR submitted to blitzjs.com for any user facing changes

@ryardley
Copy link
Collaborator Author

ryardley commented Jul 8, 2020

Just realised we are not doing path transformation when imports don't use the from syntax with an import specifier. So adding it to this PR.

@ryardley ryardley marked this pull request as ready for review July 8, 2020 07:30
@ryardley ryardley requested review from flybayer and merelinguist July 8, 2020 07:38
Copy link
Member

@flybayer flybayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@flybayer flybayer changed the title Do not copy non tjsx pages to pages Fix issue with using non-page files inside pages folders Jul 8, 2020
@flybayer flybayer merged commit 342782f into canary Jul 8, 2020
@flybayer flybayer deleted the 415-non-js-pages branch July 8, 2020 10:11
@itsdillon itsdillon changed the title Fix issue with using non-page files inside pages folders [legacy-framework] Fix issue with using non-page files inside pages folders Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't use non-js/ts files inside pages/ folders

2 participants