Add signal when transaction found in wallet, and filtering on wallet#102
Add signal when transaction found in wallet, and filtering on wallet#102dangershony merged 1 commit intomasterfrom
Conversation
sondreb
commented
Apr 23, 2020
sondreb
commented
- Add a signal when transactoin is found in wallet.
- Add options to filter what is returned from Accounts, Transactions and Balances.
- Add a signal when transactoin is found in wallet. - Add options to filter what is returned from Accounts, Transactions and Balances.
| // Start the syncing process from the block before the earliest transaction was seen. | ||
| this.walletSyncManager.SyncFromHeight(chainedHeader.Height - 1); | ||
| // Start the sync from the day before it was created. | ||
| this.walletSyncManager.SyncFromHeight(chainedHeader.Height); |
There was a problem hiding this comment.
It previously synced just minus 1 block, now it syncs minus 1 day, see 3rd line from above this line.
| /// <summary> | ||
| /// The wallet name set by selectwallet method. This is static since the controller is a stateless type. This value should probably be cached by an injected service in the future. | ||
| /// </summary> | ||
| private static string CurrentWalletName; |
There was a problem hiding this comment.
I think we should fix this now, it will be a fast fix maybe use as a hack put the field on the WallletManager just to avoid it being static?
There was a problem hiding this comment.
Ah I realize this is on RPC, it less crucial for me so this is fine (if it does not break tests)
There was a problem hiding this comment.
Doesn't break anything, and it is to give a custom support for multi-wallet in the RPC. It's a fairly important extra RPC method for anyone who relies on the RPC and have multiple wallets, but I don't think there are many that will ever use this. It is very useful when debugging and working with multiple wallets at the same time (normal wallet and special wallets).
dangershony
left a comment
dangershony
left a comment
There was a problem hiding this comment.
Brilliant I suggest I run tests locally to be sure it all works
2 participants
