Skip the transaction details for cold staking scripts#89
Closed
sondreb wants to merge 1 commit intoblock-core:masterfrom
sondreb:feature/skip-details
Closed
Skip the transaction details for cold staking scripts#89sondreb wants to merge 1 commit intoblock-core:masterfrom sondreb:feature/skip-details
sondreb wants to merge 1 commit intoblock-core:masterfrom
sondreb:feature/skip-details
Conversation
Member
sondreb
commented
Apr 9, 2020
sondreb
commented
- There is no need for the transaction details on the cold staking transaction, so simply skip it.
- There is no need for the transaction details on the cold staking transaction, so simply skip it.
dangershony
approved these changes
Apr 9, 2020
Member
dangershony
left a comment
dangershony
left a comment
There was a problem hiding this comment.
It looks correct to me, let me run all tests on this locally
Member
Author
|
This PR is superseeded by #102 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.