Adding Rutanio Network (RUTA)#161
Merged
dangershony merged 17 commits intoblock-core:masterfrom Jun 24, 2020
Merged
Conversation
… differents daemons (i.e: ElectrumX)
sondreb
approved these changes
Jun 22, 2020
Member
sondreb
left a comment
There was a problem hiding this comment.
Did a quick review and looks fine, I also ran the code and it syncs.
Member
|
hold on with pushing @sondreb I'll review this today too |
dangershony
reviewed
Jun 22, 2020
dangershony
reviewed
Jun 22, 2020
dangershony
reviewed
Jun 22, 2020
dangershony
reviewed
Jun 22, 2020
dangershony
reviewed
Jun 22, 2020
dangershony
reviewed
Jun 22, 2020
dangershony
reviewed
Jun 22, 2020
dangershony
reviewed
Jun 22, 2020
dangershony
requested changes
Jun 22, 2020
Member
dangershony
left a comment
There was a problem hiding this comment.
Ok very good PR some comments need to be dealt with first bt generally looks good.
Contributor
Author
|
dangershony
reviewed
Jun 24, 2020
|
|
||
| /// <summary>Use title from agent</summary> | ||
| public string APITitle { get; set; } | ||
| public string ApiTitle { get; set; } |
Member
There was a problem hiding this comment.
ok good let me run tests locally then I push
dangershony
approved these changes
Jun 24, 2020
Member
dangershony
left a comment
There was a problem hiding this comment.
Just finishing tests and it can go in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default is: application/json; chartset=utf-8
You can call it from console like this:
To connect with other daemons like ElectrumX, you can use it like this: