Skip to content

Adding Rutanio Network (RUTA)#161

Merged
dangershony merged 17 commits intoblock-core:masterfrom
FluidChains:1.0.10
Jun 24, 2020
Merged

Adding Rutanio Network (RUTA)#161
dangershony merged 17 commits intoblock-core:masterfrom
FluidChains:1.0.10

Conversation

@turcol
Copy link
Copy Markdown
Contributor

@turcol turcol commented Jun 22, 2020

  • There is a different favicon per network
  • The swagger title includes the network name
  • The Network Agent name includes now the network name
  • The hashkey can be overridden for each network that requires it
  • The RPCContentType can be loaded with or without the charset.
    The default is: application/json; chartset=utf-8
    You can call it from console like this:
    • rpccontentype=<string>
      To connect with other daemons like ElectrumX, you can use it like this:
    • rpccontentype="application/json"

Copy link
Copy Markdown
Member

@sondreb sondreb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick review and looks fine, I also ran the code and it syncs.

Comment thread src/Node/Blockcore.Node/NodeBuilder.cs Outdated
Comment thread src/Features/Blockcore.Features.NodeHost/UI/Pages/_Host.cshtml Outdated
@dangershony
Copy link
Copy Markdown
Member

hold on with pushing @sondreb I'll review this today too

Comment thread src/Features/Blockcore.Features.NodeHost/NodeHostSettings.cs Outdated
Comment thread src/Features/Blockcore.Features.NodeHost/Startup.cs Outdated
Comment thread src/Features/Blockcore.Features.RPC/RPCFeature.cs
Comment thread src/Networks/Rutanio/Rutanio/Networks/Policies/RutanioStandardScriptsRegistry.cs Outdated
Comment thread src/Networks/Rutanio/Rutanio/Networks/RutanioMain.cs
Comment thread src/Networks/Rutanio/Rutanio/Networks/RutanioMain.cs Outdated
Comment thread src/Networks/Rutanio/Rutanio/Rutanio.csproj Outdated
Copy link
Copy Markdown
Member

@dangershony dangershony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok very good PR some comments need to be dealt with first bt generally looks good.

@turcol
Copy link
Copy Markdown
Contributor Author

turcol commented Jun 24, 2020

Please make this "ApiTitle", more readable. Thanks! =)
Done. Thanks for the suggestion!


/// <summary>Use title from agent</summary>
public string APITitle { get; set; }
public string ApiTitle { get; set; }
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok good let me run tests locally then I push

Copy link
Copy Markdown
Member

@dangershony dangershony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just finishing tests and it can go in

@turcol turcol requested a review from dangershony June 24, 2020 22:21
@dangershony dangershony merged commit 6dac1ff into block-core:master Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants