Add Blockcore.Node project for quick and easy debug of multiple chains#115
Merged
dangershony merged 1 commit intomasterfrom May 6, 2020
Merged
Add Blockcore.Node project for quick and easy debug of multiple chains#115dangershony merged 1 commit intomasterfrom
dangershony merged 1 commit intomasterfrom
Conversation
Member
sondreb
commented
May 6, 2020
sondreb
commented
- Adds a new project that can launch multiple chains based on startup argument. This allows us to remove the existing node projects, they are no longer needed.
- Adds a new project that can launch multiple chains based on startup argument. This allows us to remove the existing node projects, they are no longer needed.
dangershony
reviewed
May 6, 2020
| NodeSettings nodeSettings = NetworkSelector.Create(chain, args); | ||
| IFullNodeBuilder nodeBuilder = NodeBuilder.Create(chain, nodeSettings); | ||
|
|
||
| if (nodeSettings.EnableSignalR) |
Member
There was a problem hiding this comment.
argh this stuff should be hidden in the feature (well that's for another PR)
Member
Author
There was a problem hiding this comment.
The SignalR parts? Yes it should.
dangershony
approved these changes
May 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.