Migrate SignalR feature into WebHost#121
Merged
dangershony merged 15 commits intomasterfrom May 14, 2020
Merged
Conversation
Member
sondreb
commented
May 12, 2020
sondreb
commented
- Migrate the SignalR feature into WebHost.
- Further refactor WebHost from "Api" to "WebHost.
- Remove the versioning support from REST API.
- Enable flags to enable/disable UI, API and WS.
- Generate and include XML documentation in the REST API for all features.
- Add a basic example on Web Socket listener.
- Migrate the SignalR feature into WebHost. - Further refactor WebHost from "Api" to "WebHost. - Remove the versioning support from REST API. - Enable flags to enable/disable UI, API and WS. - Generate and include XML documentation in the REST API for all features. - Add a basic example on Web Socket listener.
dangershony
reviewed
May 12, 2020
dangershony
reviewed
May 12, 2020
dangershony
reviewed
May 12, 2020
dangershony
reviewed
May 12, 2020
dangershony
reviewed
May 12, 2020
dangershony
reviewed
May 12, 2020
dangershony
reviewed
May 12, 2020
dangershony
reviewed
May 12, 2020
dangershony
reviewed
May 12, 2020
| public Timer KeepaliveTimer { get; private set; } | ||
|
|
||
| /// <summary> | ||
| /// If true then the node will add and start the SignalR feature. This should never be enabled if node is accessible to the public. |
Member
There was a problem hiding this comment.
Are they on by default? should we document that?
Member
Author
There was a problem hiding this comment.
this.EnableWS = config.GetOrDefault("enableWS", false, this.logger);
this.EnableUI = config.GetOrDefault("enableUI", true, this.logger);
this.EnableAPI = config.GetOrDefault("enableAPI", true, this.logger);
Probably document somewhere, and we should decide what we want on by default.
dangershony
reviewed
May 12, 2020
dangershony
reviewed
May 12, 2020
dangershony
reviewed
May 12, 2020
Member
dangershony
left a comment
dangershony
left a comment
There was a problem hiding this comment.
Brilliant PR just the one comment to move broadcasters to their parent projects and this is good
MithrilMan
reviewed
May 13, 2020
- Return the EventBase directly to Web Socket consumers. - Remove unused code. - Remove references in WebHost project.
- Move the Assembly extension from Swagger scaffolding to Utilities. - Minor bug discovered in dispose when object is null (happened during an integration test).
- Next commit will rename the physical folder.
- Updates all references, etc. from WebHost to NodeHost.
dangershony
reviewed
May 13, 2020
| { | ||
| this.logger.LogInformation("Flushing peers."); | ||
| this.flushAddressManagerLoop.Dispose(); | ||
| if (this.flushAddressManagerLoop != null) |
dangershony
reviewed
May 13, 2020
dangershony
reviewed
May 13, 2020
dangershony
reviewed
May 14, 2020
Member
dangershony
left a comment
dangershony
left a comment
There was a problem hiding this comment.
Brilliant commit, I am gonna push a small change to fix the static service provider field.
- We're returning the whole object in the evernt, no longer needed to read out hash and height.
This reverts commit 4f8af1b.
…om/block-core/blockcore into feature/migrate-signalr-to-webhost
- Minor cleanup of events, removing older properties.
- Update to use relative path when hosted on the NodeHost. - Add JsonIgnore on objects that can't serialize. This needs to be added to more.
…h node - Certain types will crash the node when sent to the Web Socket consumer. - Beware of this issue in the future when working on the event types. - Remove the EventType and instead only have EventName.
…ice is registered - When using the node without .UseWebHost, no implementation of IEventsSubscriptionService is registered. This fixes the broadcasters by handling them as empty if one is not provided.
dangershony
reviewed
May 14, 2020
- Reverted the changes to check for nulls on IBD check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.