Skip to content

Added listtransactions RPC#159

Merged
dangershony merged 8 commits intoblock-core:masterfrom
x42protocol:List-Transactions-RPC
Jun 30, 2020
Merged

Added listtransactions RPC#159
dangershony merged 8 commits intoblock-core:masterfrom
x42protocol:List-Transactions-RPC

Conversation

@DennisAMenace
Copy link
Copy Markdown
Contributor

@DennisAMenace DennisAMenace commented Jun 18, 2020

Task notes:

A little different from listtransactions (0.20.0 RPC)

  • The result does not have all of the data that the (0.20.0 RPC) provides, but I think we can keep adding to this later in more PR's as needed.

@dangershony
Copy link
Copy Markdown
Member

label (AKA account in previous versions of BTC Core) was depreciated in 0.14 so I added this parameter for backwards compatibility, but it does nothing.

What backwards compatibility needs that and cant we just fix it there?
I am afriad we will carry this tech debt for a long tie if we put it back

@DennisAMenace
Copy link
Copy Markdown
Contributor Author

label (AKA account in previous versions of BTC Core) was depreciated in 0.14 so I added this parameter for backwards compatibility, but it does nothing.

What backwards compatibility needs that and cant we just fix it there?
I am afriad we will carry this tech debt for a long tie if we put it back

No problem, Done. I added this in to allow the selection of the account in the last commit.


/// <summary>
/// TODO: Make this internal when the component moves to Stratis.Bitcoin
/// TODO: Make this internal when the component moves to Blockcore
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah brilliant job

Comment thread src/Features/Blockcore.Features.Notifications/AssemblyInfo.cs Outdated
[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Style", "IDE1006:Naming Styles", Justification = "<Pending>", Scope = "member", Target = "~M:Stratis.Bitcoin.IntegrationTests.Miners.ProofOfStakeMintCoinsSpecification.pos_node_wallet_has_earned_coins_through_staking")]
[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Style", "IDE1006:Naming Styles", Justification = "<Pending>", Scope = "member", Target = "~M:Stratis.Bitcoin.IntegrationTests.Miners.ProofOfStakeMintCoinsSpecification.pow_wallet_broadcasts_tx_of_million_coins_and_pos_wallet_receives")]
[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Style", "IDE1006:Naming Styles", Justification = "<Pending>", Scope = "member", Target = "~M:Stratis.Bitcoin.IntegrationTests.SmartContracts.SmartContractMinerTests.SmartContract_ReferencingInputInSameBlock~System.Threading.Tasks.Task")] No newline at end of file
[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Style", "IDE1006:Naming Styles", Justification = "<Pending>", Scope = "member", Target = "~M:Blockcore.IntegrationTests.Miners.ProofOfStakeMintCoinsSpecification.a_proof_of_stake_node_with_wallet")]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah good good I cant believe I missed that

Copy link
Copy Markdown
Member

@dangershony dangershony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@dangershony
Copy link
Copy Markdown
Member

@DennisAMenace please just fix the conflict and we push this

@dangershony dangershony merged commit 1e6013a into block-core:master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants