Skip to content

Improve loading of peers.json for corrupt peers.json file #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sondreb merged 1 commit into from
Aug 26, 2020
Merged

Improve loading of peers.json for corrupt peers.json file #207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion src/Blockcore/P2P/PeerAddressManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,25 @@ public PeerAddressManager(IDateTimeProvider dateTimeProvider, DataFolder peerFil
/// <inheritdoc />
public void LoadPeers()
{
List<PeerAddress> loadedPeers = this.fileStorage.LoadByFileName(PeerFileName);
List<PeerAddress> loadedPeers;

try
{
loadedPeers = this.fileStorage.LoadByFileName(PeerFileName);
}
catch (Exception e)
{
this.logger.LogError("Error loading peers JSON, defaulting to empty list: {0}", e);

loadedPeers = new List<PeerAddress>();
}

if (loadedPeers == null)
loadedPeers = new List<PeerAddress>();

// If the loaded peers is still empty at this point, we rely on the discovery loop to find new peers to connect to.
// The discovery loop will only not run if -connect is used or if there are un-attempted peers left, so as long as
// there are seed nodes & DNS seeds available we should get something to connect to relatively rapidly.

this.logger.LogDebug("{0} peers were loaded.", loadedPeers.Count);

Expand Down