Changed LiteDB to v4 for stability.#242
Changed LiteDB to v4 for stability.#242sondreb merged 16 commits intoblock-core:masterfrom DennisAMenace:master
Conversation
| .GroupBy(x => x.BlockHeight != null) | ||
| .ToList(); | ||
|
|
||
| var sql = "SELECT " + |
There was a problem hiding this comment.
How confident are you about this?
I am not sure we have tests here.
There was a problem hiding this comment.
Give me a day to run through some manual testing, I will let you know when it is ready.
There was a problem hiding this comment.
Hi @dangershony, this is ready as I've made the final adjustments. I've done all of my manual tests, but I cannot run the automated unit tests because the ReadyData needs to be regenerated.
How confident are you about this?
I am not sure we have tests here.
There are a couple tests for this method, but we need the readydata to be regenerated for it.
|
I will pull the branch to merge master and regenerate the tests |
|
I merged this with master to get the fixed tests. Any help to finish this PR would be good @dangershony as it will fix our stability issues - thank you. The file wallet-with-funds.db needs to be regenerated with the right amount of blocks, or change this to be automatic. |
|
I am not sure what was decided with this problem? do we downgrade? @sondreb |
- Rename the database file name for addressindexer. This means users must manually delete the old file to clear up disk space. - Attempt to read the wallet database and if it fails, attempt to rename it away and try again (only one time).
- The "affectedAddresses" query fails and must be updated to work properly with LiteDB V4.
- This fixes a crash that occured due to LINQ resulting in an invalid query against V4 of LiteDB. Reverted back to old syntax.
- Improves the purge performance greatly by using query to perform a bulk delete.
|
I have improved the V4 performance and we'll merge this. An update to wallet test files is needed to ensure that integration tests works. |
3 participants
Discussion in Discord, Dan will add ReadyData for the tests before this is added in.