Wallet db to use sqlite (instead of litedbv4)#272
Conversation
sondreb
left a comment
There was a problem hiding this comment.
How is persistence done? Appears to store a lot of IO to disk, perhaps there is an interval settings key that can be set a bit higher? Maybe increase it during IBD?
|
It will push on every trx that we find for the wallet, I don't think sqlite has a cache mechanism I didn't check. |
sondreb
left a comment
There was a problem hiding this comment.
Have verified the performance, works very well. Have not done properly code review yet, will do later if not merged yet, but approval so far.
|
Any reason why not implementing this like other "persistence-aware" components and be able to switch db implementation at will? |
Well perhaps it can be done but I want to first get something working. |
|
I did a review and this is brilliant. I don't think we had index's before with LiteDB, now we do with SQLite, great work @dangershony Can't wait to give this a try! |
|
All tests now passed locally and I see mac tests passed too. |
MithrilMan
left a comment
There was a problem hiding this comment.
ok, commented a bit :)
The main db tests are now passing.
I still need to run all the solution tests and then also compare to other wallets on current networks