fix(sessions): drop the redundant In progress footer row from tool call details - #910
Conversation
…ll details The expanded tool call card ended its output with an "In progress" status row, but the header's status dot already shows a clock icon for running calls, so the row repeated information without adding any. Extend the existing success-row suppression in OutputSections.svelte to the running tone as well; failed, cancelled, and pending rows still render. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Matt Toohey <contact@matttoohey.com>
Review feedback on d1b3fc7: the footer-row condition had grown into a two-tone exclusion list, expressing "which tones add information" as its negation. Invert it to an explicit allow-list (danger, cancelled, muted) so the intent reads directly and any future tone must consciously opt in to rendering the row instead of defaulting to shown. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Matt Toohey <contact@matttoohey.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d76ed85515
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| <!-- Success and in-progress rows only echo the check and clock icons already | ||
| in the card header, so the footer status shows only when it adds something | ||
| (failed, cancelled, pending). --> | ||
| {#if includeStatus && ['danger', 'cancelled', 'muted'].includes(viewModel.statusTone)} |
There was a problem hiding this comment.
When an in-progress tool already has output, this allow-list removes the only textual In progress status from the expanded details. I checked the header path (ToolCallHeader.svelte passes only statusTone, and ToolStatusDot.svelte renders an unlabeled icon), so the clock remains only a visual cue and screen-reader users no longer get the running state after opening the details; if the footer is hidden, expose statusLabel in the header/dot instead.
Useful? React with 👍 / 👎.
1 participant
The expanded tool call card ended its output with an "In progress" status row, but the header's status dot already shows a clock icon for running calls — so the row repeated information without adding any.
OutputSections.sveltealready suppressed the footer row for thesuccesstone for the same reason (it echoed the header's green check). Rather than growing that into a two-tone exclusion list, the condition is now an explicit allow-list of the tones that actually add information:danger,cancelled, andmuted(pending). Any future tone has to consciously opt in to rendering the row instead of defaulting to shown.Net effect: failed, cancelled, and pending rows still render; success and in-progress rows do not.