Skip to content

fix(sessions): drop the redundant In progress footer row from tool call details #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matt2e merged 2 commits into from
Aug 7, 2026
Merged

fix(sessions): drop the redundant In progress footer row from tool call details #910

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1b3fc7
fix(sessions): drop the redundant In progress footer row from tool ca…
matt2e Aug 7, 2026
d76ed85
refactor(sessions): allow-list the tones that render a footer status row
matt2e Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions apps/staged/src/lib/features/sessions/tool-calls/OutputSections.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,10 +131,10 @@
<div class="tool-empty-row">{viewModel.output.emptyLabel}</div>
{/if}

<!-- A success row only echoes the green check already in the card header, so
the footer status shows only when it adds something (failed, cancelled,
still running). -->
{#if includeStatus && viewModel.statusTone !== 'success'}
<!-- Success and in-progress rows only echo the check and clock icons already
in the card header, so the footer status shows only when it adds something
(failed, cancelled, pending). -->
{#if includeStatus && ['danger', 'cancelled', 'muted'].includes(viewModel.statusTone)}

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve accessible in-progress status

When an in-progress tool already has output, this allow-list removes the only textual In progress status from the expanded details. I checked the header path (ToolCallHeader.svelte passes only statusTone, and ToolStatusDot.svelte renders an unlabeled icon), so the clock remains only a visual cue and screen-reader users no longer get the running state after opening the details; if the footer is hidden, expose statusLabel in the header/dot instead.

Useful? React with 👍 / 👎.

<div
class="tool-code-status"
class:status-danger={viewModel.statusTone === 'danger'}
Expand Down