fix(desktop): surface relay profile-sync failure on agent rename#2302
Open
Bartok9 wants to merge 1 commit into
Open
fix(desktop): surface relay profile-sync failure on agent rename#2302Bartok9 wants to merge 1 commit into
Bartok9 wants to merge 1 commit into
Conversation
Bartok9
force-pushed
the
bartok9/rename-profile-sync-feedback
branch
from
July 21, 2026 22:12
41a2797 to
dd70b9a
Compare
When renaming an agent, the local save (disk + AGENTS.md) always succeeds, but the async relay kind:0 profile republish can fail (network blip, auth expiry, relay unreachable). The edit dialog only `console.warn`-ed that error and closed as if the rename fully succeeded, so the user never learned the relay still had the old name/@mention handle (block#1822). Surface it with a warning toast — matching the create and persona flows, which already toast `profileSyncError`. Local-save behavior is unchanged. Refs block#1822 Signed-off-by: Bartok9 <danielrpike9@gmail.com>
Bartok9
force-pushed
the
bartok9/rename-profile-sync-feedback
branch
from
July 22, 2026 14:33
dd70b9a to
00664ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1822
Problem
Renaming an agent runs two phases in
update_managed_agent:display_name. This can fail (network blip, auth expiry, relay unreachable).The Tauri command already returns
profile_sync_error: Option<String>, but the edit dialog's success handler onlyconsole.warn-ed it and then closed the dialog as if the rename fully succeeded. The user had no way to know the relay still advertised the old name (and old @mention handle) — a silent, confusing partial failure.Fix
Surface
profileSyncErrorwith a warning toast:This matches how the create flow (
useManagedAgentActions/SecretRevealDialog) and the persona flow (usePersonaActions) already surface the same field. Local-save behavior is unchanged; the dialog still closes (the save did happen) but the user is now told the relay is stale and can retry.How to test
pnpm typecheck— cleanpnpm exec biome checkon the file — cleanManual: rename an agent while the relay is unreachable → a warning toast reports the profile-sync failure instead of the rename appearing fully successful.
Scope
Just the missing user feedback for the profile-sync seam. The separate, larger issue of notifying running agents mid-session about the rename (#1823) is intentionally out of scope.
Signed-off-by DCO.