Skip to content

fix(desktop): surface relay profile-sync failure on agent rename #2302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bartok9 wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −0
Open

fix(desktop): surface relay profile-sync failure on agent rename #2302

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions desktop/src/features/agents/ui/AgentInstanceEditDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -726,6 +726,17 @@ export function AgentInstanceEditDialog({
autoRestartOnConfigChange,
);
}
if (result.profileSyncError) {
// The local save (disk + AGENTS.md) already succeeded, but the relay
// still has the old kind:0 profile (e.g. old @mention name). Surface
// it instead of silently closing — otherwise the dialog closes as if
// the rename fully succeeded and the user never learns the relay is
// stale (#1822). Matches the create/persona flows, which already toast
// profileSyncError.
toast.warning(
`${result.agent.name} saved locally, but relay profile sync failed: ${result.profileSyncError}`,
);
}
handleOpenChange(false);
onUpdated?.(result.agent);
// The auto-restart policy deliberately never fires for a stopped or
Expand Down