Skip to content

fix(desktop): isolate relay admission tests - #5221

Merged
wesbillman merged 1 commit into
mainfrom
carl-fix-relay-admission-test-isolation
Aug 7, 2026
Merged

fix(desktop): isolate relay admission tests#5221
wesbillman merged 1 commit into
mainfrom
carl-fix-relay-admission-test-isolation

Conversation

@wesbillman

Copy link
Copy Markdown
Collaborator

Summary

  • serialize the relay error-message test with all other tests mutating the process-wide admission gate
  • clear its 300-second rate-limit expiry after the assertion
  • prevent the paused-time waiter test from observing another test's state

Root cause

relay::tests::oversized_hint_is_capped_in_relay_error_message_string arms the process-wide gate for 300 seconds without taking TEST_SERIAL or resetting it. In a parallel test run, relay_admission::tests::concurrent_429_extends_the_window_for_parked_waiters can observe that expiry, producing the reported 300.001s instead of 5s.

Validation

  • focused admission suite + relay error test repeated 10 times
  • pre-push desktop-tauri-checks passed, including the full Rust workspace suite
  • branch-skew passed

Serialize the relay error test with other tests that mutate the process-wide
rate-limit gate, and clear its 300-second expiry after the assertion.

Co-authored-by: Carl <c7ebe626f000404285d3686e1dc74cc07cc60a9754a150041ba132e14bd3e2ec@buzz.block.builderlab.xyz>
Signed-off-by: Wes <wesbillman@users.noreply.github.com>
@wesbillman
wesbillman requested a review from a team as a code owner August 7, 2026 18:29
@wesbillman
wesbillman merged commit 74b913c into main Aug 7, 2026
26 checks passed
@wesbillman
wesbillman deleted the carl-fix-relay-admission-test-isolation branch August 7, 2026 22:09
wpfleger96 pushed a commit that referenced this pull request Aug 7, 2026
…format

* origin/main: (60 commits)
  feat(desktop): unify add agent flows (#5015)
  fix(buzz-agent): budget summarizer reasoning separately so it cannot starve the handoff summary (#5248)
  infra: bind development services to loopback (#4871)
  chore(release): release Buzz Desktop version 0.5.7 (#5252)
  fix(desktop): isolate relay admission tests (#5221)
  fix(desktop): externalize boot <style> to prevent Tauri CSP nonce override (#5242)
  fix(desktop): let imported and recovered identities finish onboarding (#5228)
  Recover from max-token response truncation (#5223)
  chore(release): release Buzz Desktop version 0.5.6 (#5214)
  fix(mobile): keep latest messages above composer (#4981)
  fix(sdk): preserve self-mention p tags in message and forum event builders (#4975)
  bump @tauri-apps/cli to ~2.11.4 to fix linux app icon issue (#4858)
  feat(desktop): adding rich link previews to messages (#3818)
  fix(buzz-agent): Responses reasoning summary, Anthropic display:summarized, ACP v2 messageId (#5195)
  fix(desktop): retain distinct agent instances in autocomplete (#5202)
  fix(desktop): defer channel visibility change to Save (#5203)
  feat(desktop): Projects follow-ups — access restrictions, fast loading, activity feed polish (#5073)
  refactor(cli): replace probe/decider/detail split with single typed extractor (#5191)
  fix(desktop): drop unhandled rejection from throwing window.Notification (#5143)
  fix(desktop): fence localStorage SecurityError from killing the React tree (#5142)
  ...

Signed-off-by: Duncan <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant