Revert "fix(acp): reject unattended permission requests" - #5323
Merged
wesbillman merged 1 commit intoAug 8, 2026
Conversation
This reverts commit ad538bf.
wpfleger96
approved these changes
Aug 8, 2026
|
@wesbillman The revert restores agent function, but it also makes It keeps The regression drives a real fake adapter through the prompt wire, captures the exact permission response, and proves the turn completes. All 688 ACP tests, strict Clippy, formatting, and the adversarial pass are clean. You can cherry-pick this before merge. |
wesbillman
deleted the
revert-4609-codex/security-acp-shell-auto-approval
branch
August 8, 2026 15:43
|
@wesbillman @wpfleger96 The revert merged before the cherry-pick. I restacked the exact reviewed commit onto the new main as #5325. It is one signed commit, passes the full ACP gate locally, and keeps #5106's policy path open without delaying the recovery. |
tlongwell-block
pushed a commit
that referenced
this pull request
Aug 8, 2026
…ounting-and-solo * origin/main: chore(release): release Buzz Desktop version 0.5.8 (#5326) fix(buzz-agent): recover from 400-shaped image rejections; unbound benchmark agent rounds (#5318) Revert "fix(acp): reject unattended permission requests" (#5323) feat(desktop): unify add agent flows (#5015) Co-authored-by: Eva <011987e296fd5006292d2f930b574be47c7801048d1983c46c425d3c95f0cffd@buzz.block.builderlab.xyz> Signed-off-by: Eva <011987e296fd5006292d2f930b574be47c7801048d1983c46c425d3c95f0cffd@buzz.block.builderlab.xyz>
wpfleger96
pushed a commit
that referenced
this pull request
Aug 8, 2026
* origin/main: chore(release): release Buzz Desktop version 0.5.8 (#5326) fix(buzz-agent): recover from 400-shaped image rejections; unbound benchmark agent rounds (#5318) Revert "fix(acp): reject unattended permission requests" (#5323) feat(desktop): unify add agent flows (#5015) fix(buzz-agent): budget summarizer reasoning separately so it cannot starve the handoff summary (#5248) infra: bind development services to loopback (#4871) Signed-off-by: Duncan <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz> # Conflicts: # CHANGELOG.md
wpfleger96
added a commit
that referenced
this pull request
Aug 8, 2026
* origin/main: fix(desktop): welcome banner overlap and missing dismiss control (#5330) fix(desktop): prevent horizontal clipping in Prompt Context modal (#5324) chore(release): release Buzz Relay version 0.2.1 (#2856) chore(release): release Buzz Desktop version 0.5.8 (#5326) fix(buzz-agent): recover from 400-shaped image rejections; unbound benchmark agent rounds (#5318) Revert "fix(acp): reject unattended permission requests" (#5323) feat(desktop): unify add agent flows (#5015) fix(buzz-agent): budget summarizer reasoning separately so it cannot starve the handoff summary (#5248) infra: bind development services to loopback (#4871) chore(release): release Buzz Desktop version 0.5.7 (#5252) fix(desktop): isolate relay admission tests (#5221) fix(desktop): externalize boot <style> to prevent Tauri CSP nonce override (#5242) fix(desktop): let imported and recovered identities finish onboarding (#5228) Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
wpfleger96
added a commit
that referenced
this pull request
Aug 8, 2026
The 74c9200 merge let main's revert-of-#4609 semantics leak into branch-owned buzz-acp code. Specifically: - config.rs: BypassPermissions variant reintroduced with no guard in PermissionConfig::resolve; test_default_config_uses_bypass_permissions asserted effective_mode == DontAsk - pool.rs: ResolvedPermissionConfig replaced with bare PermissionMode, relay_event_publisher/permission_decision_tx stripped, sentinel wiring removed from run_prompt_task, doc comments spliced mid-sentence - acp.rs: test helpers options()/outcome() deleted while call sites remained (5 E0425 compile errors); find_allow_once_returns_none_when_absent body corrupted with undefined `response` variable - lib.rs: import regression Fix: restore all four crates/buzz-acp files to the branch tip (d808c4b) which correctly supersedes both #4609 and its revert #5323. No semantics from the revert survive on this branch. Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #4609