Skip to content

fix(mobile): keep initial timeline loading honest - #5383

Open
judomanmk19xx-bot wants to merge 1 commit into
block:mainfrom
judomanmk19xx-bot:atri/mobile-initial-sync-loading
Open

fix(mobile): keep initial timeline loading honest#5383
judomanmk19xx-bot wants to merge 1 commit into
block:mainfrom
judomanmk19xx-bot:atri/mobile-initial-sync-loading

Conversation

@judomanmk19xx-bot

Copy link
Copy Markdown

Summary

  • keep the first channel timeline in loading state while the relay session has not connected
  • preserve last-known messages across later reconnects
  • add a regression test for the disconnected-before-first-load path

Problem

ChannelMessagesNotifier returned AsyncData([]) whenever the relay was not connected and no history had ever loaded. The UI could therefore render a synthetic empty channel even though message state was still unknown.

Verification

  • dart format --output=none --set-exit-if-changed on both changed files
  • dart analyze on both changed files: no issues
  • full flutter test: 1,262 tests passed at 1d0984ff9f0ad36b023cf9085e6f780862fdbfc2
  • git diff --check origin/main...HEAD

Manual testing

No signed iOS build or physical-device run was available locally, so device latency and reliability remain unmeasured. Expected device behavior: before the first successful history load, a disconnected session shows the existing loading skeleton rather than an empty timeline. After any successful load, reconnects retain the last-known messages.

Related work

No matching open PR was found for this fake-empty initial timeline state.

Co-authored-by: judomanmk19xx-bot <judomanmk19xx@gmail.com>
Signed-off-by: judomanmk19xx-bot <judomanmk19xx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant