Fix/id field non nullable json schema#1118
Merged
myronmarston merged 7 commits intoblock:mainfrom Apr 8, 2026
Merged
Conversation
The Goose docs moved from block.github.io/goose to goose-docs.ai, causing a 404 in the HTML-Proofer CI check.
rossroberts-toast
requested review from
BrianSigafoos-SQ,
ayousufi,
bsorbo,
jwils,
jwondrusch and
myronmarston
as code owners
myronmarston
requested changes
Apr 8, 2026
Collaborator
myronmarston
left a comment
myronmarston
left a comment
There was a problem hiding this comment.
This is great, thanks! Two suggestions:
- Can you rebase on latest
main? That should fix the CI failure. - Can you also update
Team.idhere fromID!toIDso that it exercises this? We like using our test schema to exercise a wide variety of cases and a reason we hadn't noticed this before now is that all the indexed types in our test schema useID!as the GraphQL type.
…ssroberts-toast/elasticgraph into fix/id-field-non-nullable-json-schema merged main into branch
Contributor
Author
|
that change seemed to introduce some test failures. looking into them now. |
myronmarston
approved these changes
Apr 8, 2026
myronmarston
added a commit
that referenced
this pull request
Apr 8, 2026
…pes. After merging #1118, I realized that there's an alternate implementation that would pass the test added in that PR but would be wrong: we could always set the `id` field of any object type to be non-nullable. We only want to do so on indexed types. This adds a test confirming that `id: ID` is left as nullable in on a non-indexed type.
myronmarston
added a commit
that referenced
this pull request
Apr 9, 2026
…pes. (#1122) After merging #1118, I realized that there's an alternate implementation that would pass the test added in that PR but would be wrong: we could always set the `id` field of any object type to be non-nullable. We only want to do so on indexed types. This adds a test confirming that `id: ID` is left as nullable in on a non-indexed type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to ensure that the required ID field in the json schema of any top level document is non-nullable. This should resolve the bug raised here: #1117