Add test coverage: don't make id: ID non-nullable on non-indexed types.#1122
Merged
myronmarston merged 1 commit intomainfrom Apr 9, 2026
Merged
Add test coverage: don't make id: ID non-nullable on non-indexed types.#1122myronmarston merged 1 commit intomainfrom
id: ID non-nullable on non-indexed types.#1122myronmarston merged 1 commit intomainfrom
Conversation
…pes. After merging #1118, I realized that there's an alternate implementation that would pass the test added in that PR but would be wrong: we could always set the `id` field of any object type to be non-nullable. We only want to do so on indexed types. This adds a test confirming that `id: ID` is left as nullable in on a non-indexed type.
myronmarston
requested review from
BrianSigafoos-SQ,
ayousufi,
bsorbo,
jwils and
jwondrusch
as code owners
jwils
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After merging #1118, I realized that there's an alternate implementation that would pass the test added in that PR but would be wrong: we could always set the
idfield of any object type to be non-nullable. We only want to do so on indexed types.This adds a test confirming that
id: IDis left as nullable in on a non-indexed type.