chore: Improve CI build by validating the release workflow. - #803
Merged
Conversation
myronmarston
requested review from
BrianSigafoos-SQ,
ayousufi,
bsorbo,
jwils,
jwondrusch,
nicolewoch,
thomasmahoney and
zachbutler-squareup
as code owners
August 19, 2025 16:11
The release workflow has broken a couple times recently, and had to be fixed up via #759 and #797. The fact that the workflow is only used when we cut a release means that it does not run super often (and certainly not part of the CI build for each PR!). To help avoid breaking it in the future, I've added a new script, `script/validate_release_workflow`, which validates the brittle part of the release workflow, and I've integrated it into the CI build so that a build will fail if a change would break the release workflow.
myronmarston
force-pushed
the
myron/validate-release-workflow
branch
from
August 19, 2025 16:15
c41cac6 to
d33121e
Compare
jwondrusch
approved these changes
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release workflow has broken a couple times recently, and had to be fixed up via #759 and #797. The fact that the workflow is only used when we cut a release means that it does not run super often (and certainly not part of the CI build for each PR!).
To help avoid breaking it in the future, I've added a new script,
script/validate_release_workflow, which validates the brittle part of the release workflow, and I've integrated it into the CI build so that a build will fail if a change would break the release workflow.Testing
PR #804 builds on this and reverts the recent fix in #797 to confirm that the build fails as it should--and it did.