Only show up to 50 lines of source code by DOsinga · Pull Request #7578 · block/goose

DOsinga · 2026-02-27T18:52:04Z

Summary

Small quality of live improvement for the CLI - only show a limited number of lines when outputing code

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 490c13ea20

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-02-27T18:54:43Z

crates/goose-cli/src/session/streaming_buffer.rs

+    if lines.len() <= MAX_CODE_BLOCK_LINES {
+        return content.to_string();


Continue scanning after short first code block

truncate_code_blocks returns the original content as soon as the first fenced block has <= MAX_CODE_BLOCK_LINES, so any later oversized block is never truncated. In mixed responses (for example, a short snippet followed by a long generated file), this defeats the new 50-line cap and can still flood the CLI output, which is exactly the behavior this change intends to prevent.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: caefd4970f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-11T12:32:20Z

crates/goose-cli/src/session/streaming_buffer.rs

+    let Some(code_region) = content.get(code_start..) else {
+        return content.to_string();
+    };
+    let close_pattern = format!("\n{}", fence);


Match closing fence against opener length

truncate_code_blocks searches for the end fence using "\n```"/"\n~~~" regardless of how long the opening fence actually is, so content opened with longer fences (for example ````md blocks that embed inner ``` snippets) is treated as closed at the first inner triple fence. In that scenario, lines.len() is computed on only a prefix of the real block and oversized code blocks are left untruncated even though `check_code_fence` correctly supports longer fences.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-03-11T12:32:20Z

crates/goose-cli/src/session/streaming_buffer.rs

            let to_render = self.buffer[..safe_end].to_string();
            self.buffer = self.buffer[safe_end..].to_string();
-            Some(to_render)
+            Some(truncate_code_blocks(&to_render))


Truncate buffered markdown during flush

The truncation logic is only applied in push, but remaining buffered text is rendered through flush paths (flush_markdown_buffer) without passing through truncate_code_blocks. If a stream ends while still inside a long fenced block (the existing unclosed-code-block flow), push emits nothing and flush prints the full block, bypassing the new 50-line output cap.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 96f116296d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-11T12:56:34Z

crates/goose-cli/src/session/streaming_buffer.rs

+    let close_pattern = format!("\n{}", fence);
+    let Some(close_offset) = code_region.find(&close_pattern) else {


Recognize indented closing fences when truncating blocks

The truncation scan only looks for "\n```"/"\n~~~", so it misses valid fenced blocks whose closing fence is indented (for example list-item code blocks ending with "\n ```"). In that case truncate_code_blocks returns the full content unmodified, which bypasses the new line cap for a common Markdown pattern even though check_code_fence already treats leading spaces as valid fence syntax.

Useful? React with 👍 / 👎.

* origin/main: fix: tool confirmation handling for multiple requests (#7856) Remove dead OllamaSetup onboarding flow (#7861) fix: resolve tokio::sync::Mutex deadlock in recipe retry path (#7832) Upgrade Electron 40.6.0 → 41.0.0 (#7851) Only show up to 50 lines of source code (#7578) fix: stop writing without error when hitting broken pipe for goose session list (#7858) feat(acp): add session/set_mode handler (#7801) Keep messages in sync (#7850) More acp tools (#7843)

* main: (191 commits) fix: add tool_choice and parallel_tool_calls to chatgpt_codex provider (#7867) fix: tool confirmation handling for multiple requests (#7856) Remove dead OllamaSetup onboarding flow (#7861) fix: resolve tokio::sync::Mutex deadlock in recipe retry path (#7832) Upgrade Electron 40.6.0 → 41.0.0 (#7851) Only show up to 50 lines of source code (#7578) fix: stop writing without error when hitting broken pipe for goose session list (#7858) feat(acp): add session/set_mode handler (#7801) Keep messages in sync (#7850) More acp tools (#7843) fix: skip upgrade-insecure-requests CSP for external HTTP backends (#7714) fix(shell): prevent hang when command backgrounds a child process (#7689) Remove include from Cargo.toml in goose-mcp (#7838) Exit agent loop when tool call JSON fails to parse (#7840) chore: remove redundant husky prepare script (#7829) Add github actions workflow for unused deps (#7681) fix: prevent SSE connection drops from silently truncating responses (#7831) doc: Added notes in contribution guide for pnpm (#7833) add prefer-offline to pnpm config to skip unnecessary registry lookups (#7828) fix: remove dead read handler from DeveloperClient (#7821) ...

* main: (65 commits) feat(otel): propagate session.id to spans and log records (#7490) fix(test): add env_lock to is_openai_reasoning_model tests (#7917) fix(acp): pass session_id when loading extensions so skills are discovered (#7868) updated canonical models (#7920) feat(autovisualiser): Migrate the autovisualiser extension to MCP Apps (#7852) fix: add tool_choice and parallel_tool_calls to chatgpt_codex provider (#7867) fix: tool confirmation handling for multiple requests (#7856) Remove dead OllamaSetup onboarding flow (#7861) fix: resolve tokio::sync::Mutex deadlock in recipe retry path (#7832) Upgrade Electron 40.6.0 → 41.0.0 (#7851) Only show up to 50 lines of source code (#7578) fix: stop writing without error when hitting broken pipe for goose session list (#7858) feat(acp): add session/set_mode handler (#7801) Keep messages in sync (#7850) More acp tools (#7843) fix: skip upgrade-insecure-requests CSP for external HTTP backends (#7714) fix(shell): prevent hang when command backgrounds a child process (#7689) Remove include from Cargo.toml in goose-mcp (#7838) Exit agent loop when tool call JSON fails to parse (#7840) chore: remove redundant husky prepare script (#7829) ...

…oken-retry * origin/main: (21 commits) Remove java/.ai-usage-marker directory (#7925) test(acp): add terminal delegation fixtures and fix shell singleton (#7923) fix: bump pctx_code_mode to 0.3.0 for iterator type checking fix (#7892) feat: persist GooseMode per-session via session DB (#7854) feat(otel): propagate session.id to spans and log records (#7490) fix(test): add env_lock to is_openai_reasoning_model tests (#7917) fix(acp): pass session_id when loading extensions so skills are discovered (#7868) updated canonical models (#7920) feat(autovisualiser): Migrate the autovisualiser extension to MCP Apps (#7852) fix: add tool_choice and parallel_tool_calls to chatgpt_codex provider (#7867) fix: tool confirmation handling for multiple requests (#7856) Remove dead OllamaSetup onboarding flow (#7861) fix: resolve tokio::sync::Mutex deadlock in recipe retry path (#7832) Upgrade Electron 40.6.0 → 41.0.0 (#7851) Only show up to 50 lines of source code (#7578) fix: stop writing without error when hitting broken pipe for goose session list (#7858) feat(acp): add session/set_mode handler (#7801) Keep messages in sync (#7850) More acp tools (#7843) fix: skip upgrade-insecure-requests CSP for external HTTP backends (#7714) ...

* origin/main: (72 commits) No Check do Check (#7942) Log 500 errors and also show error for direct download (#7936) fix: retry on authentication failure with credential refresh (#7812) Remove java/.ai-usage-marker directory (#7925) test(acp): add terminal delegation fixtures and fix shell singleton (#7923) fix: bump pctx_code_mode to 0.3.0 for iterator type checking fix (#7892) feat: persist GooseMode per-session via session DB (#7854) feat(otel): propagate session.id to spans and log records (#7490) fix(test): add env_lock to is_openai_reasoning_model tests (#7917) fix(acp): pass session_id when loading extensions so skills are discovered (#7868) updated canonical models (#7920) feat(autovisualiser): Migrate the autovisualiser extension to MCP Apps (#7852) fix: add tool_choice and parallel_tool_calls to chatgpt_codex provider (#7867) fix: tool confirmation handling for multiple requests (#7856) Remove dead OllamaSetup onboarding flow (#7861) fix: resolve tokio::sync::Mutex deadlock in recipe retry path (#7832) Upgrade Electron 40.6.0 → 41.0.0 (#7851) Only show up to 50 lines of source code (#7578) fix: stop writing without error when hitting broken pipe for goose session list (#7858) feat(acp): add session/set_mode handler (#7801) ...

Only show up to 50 lines of source code

490c13e

DOsinga requested a review from alexhancock February 27, 2026 18:52

alexhancock approved these changes Feb 27, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Feb 27, 2026

View reviewed changes

Douwe Osinga added 2 commits March 2, 2026 10:46

Merge branch 'main' into fix-number-lines-cli

735304d

Redundant test

caefd49

DOsinga assigned lifeizhou-ap Mar 9, 2026

chatgpt-codex-connector bot reviewed Mar 11, 2026

View reviewed changes

fmt

96f1162

chatgpt-codex-connector bot reviewed Mar 11, 2026

View reviewed changes

DOsinga closed this Mar 11, 2026

DOsinga reopened this Mar 13, 2026

DOsinga enabled auto-merge March 13, 2026 13:45

DOsinga added this pull request to the merge queue Mar 13, 2026

Merged via the queue into main with commit de26f68 Mar 13, 2026
37 of 38 checks passed

DOsinga deleted the fix-number-lines-cli branch March 13, 2026 14:12

github-actions bot mentioned this pull request Mar 16, 2026

chore(release): release version 1.28.0 (minor) #7780

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Only show up to 50 lines of source code#7578

Only show up to 50 lines of source code#7578
DOsinga merged 4 commits intomainfrom
fix-number-lines-cli

DOsinga commented Feb 27, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Feb 27, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Mar 11, 2026

Uh oh!

chatgpt-codex-connector bot Mar 11, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Mar 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		if lines.len() <= MAX_CODE_BLOCK_LINES {
		return content.to_string();

		let close_pattern = format!("\n{}", fence);
		let Some(close_offset) = code_region.find(&close_pattern) else {

Conversation

DOsinga commented Feb 27, 2026

Summary

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants