Show setup instructions for ACP providers in settings modal#8065
Merged
michaelneale merged 2 commits intomainfrom Mar 23, 2026
Merged
Show setup instructions for ACP providers in settings modal#8065michaelneale merged 2 commits intomainfrom
michaelneale merged 2 commits intomainfrom
Conversation
ACP providers (claude-acp, codex-acp, gemini-acp) have no config_keys since they authenticate via their underlying CLI tools, not API keys. The settings modal showed a useless 'No configuration parameters' empty state with a broken 'Enable Provider' button. Changes: - Add setup_steps to all 3 ACP provider metadata with install, auth, and config.yaml instructions (GOOSE_PROVIDER + GOOSE_MODEL: current) - Update descriptions to be user-friendly - Settings modal renders setup steps as a numbered list with inline code formatting for zero-config providers with setup_steps - Show provider description instead of 'Add your API key(s)' - Show 'Close' button instead of broken 'Enable Provider' submit - Link to provider documentation Tested claude-acp and codex-acp with GOOSE_MODEL=current via goose run. Signed-off-by: Michael Neale <michael.neale@gmail.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 929e1d9d6a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
ui/desktop/src/components/settings/providers/modal/ProviderConfiguationModal.tsx
Show resolved
Hide resolved
lifeizhou-ap
approved these changes
Mar 23, 2026
Signed-off-by: Michael Neale <michael.neale@gmail.com>
wpfleger96
added a commit
that referenced
this pull request
Mar 23, 2026
* origin/main: (62 commits) Tweak the release process: no more merge to main (#7994) fix: gemini models via databricks (#8042) feat(apps): Pass toolInfo to MCP Apps via hostContext (#7506) fix: remove configured marker when deleting oauth provider configuration (#7887) docs: add vmware-aiops MCP extension documentation (#8055) Show setup instructions for ACP providers in settings modal (#8065) deps: replace sigstore-verification with sigstore-verify to kill vulns (#8064) feat(acp): add session/set_config and stabilize list, delete and close (#7984) docs: Correct `gosoe` typo to `goose` (#8062) fix: use default provider and model when provider in session no longer exists (#8035) feat: add GOOSE_SHELL env var to configure preferred shell (#7909) fix(desktop): fullscreen header bar + always-visible close controls (#8033) docs: add Claude Code approve mode permission routing documentation (#7949) chatgpt_codex: Support reasoning and gpt-5.4 (#7941) refactor(anthropic): fix N+1 thinking message storage issue (#7958) fix: handle mid-stream error events in OpenAI SSE streaming (#8031) Fix apps extension: coerce string arguments from inner LLM responses (#8030) feat: ability to expand sidebar to see chats names (#7816) Fix config for GOOSE_MAX_BACKGROUND_TASKS (#7940) set MACOSX_DEPLOYMENT_TARGET=12.0 (#7947) ...
wpfleger96
added a commit
that referenced
this pull request
Mar 23, 2026
…pstream * wpfleger/socket-support: (62 commits) Tweak the release process: no more merge to main (#7994) fix: gemini models via databricks (#8042) feat(apps): Pass toolInfo to MCP Apps via hostContext (#7506) fix: remove configured marker when deleting oauth provider configuration (#7887) docs: add vmware-aiops MCP extension documentation (#8055) Show setup instructions for ACP providers in settings modal (#8065) deps: replace sigstore-verification with sigstore-verify to kill vulns (#8064) feat(acp): add session/set_config and stabilize list, delete and close (#7984) docs: Correct `gosoe` typo to `goose` (#8062) fix: use default provider and model when provider in session no longer exists (#8035) feat: add GOOSE_SHELL env var to configure preferred shell (#7909) fix(desktop): fullscreen header bar + always-visible close controls (#8033) docs: add Claude Code approve mode permission routing documentation (#7949) chatgpt_codex: Support reasoning and gpt-5.4 (#7941) refactor(anthropic): fix N+1 thinking message storage issue (#7958) fix: handle mid-stream error events in OpenAI SSE streaming (#8031) Fix apps extension: coerce string arguments from inner LLM responses (#8030) feat: ability to expand sidebar to see chats names (#7816) Fix config for GOOSE_MAX_BACKGROUND_TASKS (#7940) set MACOSX_DEPLOYMENT_TARGET=12.0 (#7947) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ACP providers (claude-acp, codex-acp, gemini-acp) have no
config_keyssince they authenticate via their underlying CLI tools rather than API keys. The desktop settings modal showed a useless "No configuration parameters for this provider" empty state with an "Enable Provider" button that couldn't actually work (the server-side validation requires a_configuredmarker that was never set).for claude code and codex too (optionally)
Solution
Instead of trying to make the broken submit flow work, show users how to actually set up these providers:
Rust (3 ACP provider files):
setup_stepsto metadata: install npm package → authenticate CLI → setGOOSE_PROVIDER+GOOSE_MODEL: currentin~/.config/goose/config.yaml→ restart gooseUI (ProviderConfigurationModal):
setup_stepsnow show a numbered instruction list with inline code formattingTesting
Verified
GOOSE_MODEL=currentworks for all three ACP providers: