fix: handle reasoning content blocks in OpenAI-compat streaming parser#8078
Merged
wpfleger96 merged 1 commit intomainfrom Mar 23, 2026
Merged
Conversation
Adaptive thinking (#7944) sends `thinking.type = "adaptive"` to Databricks for Claude 4.6 models, but the OpenAI-compat streaming parser in openai.rs can't deserialize the resulting reasoning chunks. Databricks returns `{"type":"reasoning","summary":[...]}` content blocks which lack the `text` field that `ContentPart` requires. Make `ContentPart.text` optional so reasoning blocks deserialize without failing. The existing `filter(|p| p.r#type == "text")` in `extract_content_and_signature` already skips non-text parts, so reasoning content is naturally ignored at the extraction layer (reasoning is captured separately via `Delta.reasoning_content`). Fixes #8077
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3a3c91940d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
alexhancock
approved these changes
Mar 23, 2026
wpfleger96
added a commit
that referenced
this pull request
Mar 23, 2026
* origin/main: fix: handle reasoning content blocks in OpenAI-compat streaming parser (#8078) chore(acp): build native packages on latest mac (#8075) Display delegate sub agents logs in UI (#7519) Update tar version to avoid CVE-2026-33056 (#8073) refactor: consolidate duplicated dependencies into workspace (#8041) tui: set up for publishing via github actions (#8020) feat: feature-gate local inference dependencies (#7976) feat: ability to manage sub recipes in desktop ui (#6360)
lifeizhou-ap
added a commit
that referenced
this pull request
Mar 24, 2026
* main: (37 commits) fix: handle reasoning content blocks in OpenAI-compat streaming parser (#8078) chore(acp): build native packages on latest mac (#8075) Display delegate sub agents logs in UI (#7519) Update tar version to avoid CVE-2026-33056 (#8073) refactor: consolidate duplicated dependencies into workspace (#8041) tui: set up for publishing via github actions (#8020) feat: feature-gate local inference dependencies (#7976) feat: ability to manage sub recipes in desktop ui (#6360) Tweak the release process: no more merge to main (#7994) fix: gemini models via databricks (#8042) feat(apps): Pass toolInfo to MCP Apps via hostContext (#7506) fix: remove configured marker when deleting oauth provider configuration (#7887) docs: add vmware-aiops MCP extension documentation (#8055) Show setup instructions for ACP providers in settings modal (#8065) deps: replace sigstore-verification with sigstore-verify to kill vulns (#8064) feat(acp): add session/set_config and stabilize list, delete and close (#7984) docs: Correct `gosoe` typo to `goose` (#8062) fix: use default provider and model when provider in session no longer exists (#8035) feat: add GOOSE_SHELL env var to configure preferred shell (#7909) fix(desktop): fullscreen header bar + always-visible close controls (#8033) ...
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adaptive thinking (#7944) sends
thinking.type = "adaptive"to Databricks for Claude 4.6 models, but the OpenAI-compat streaming parser can't deserialize the resulting reasoning chunks. This causes all streaming responses to fail for Claude Opus 4.6 and Sonnet 4.6 via Databricks.Root Cause
Databricks returns content blocks like
{"type":"reasoning","summary":[...]}which lack atextfield.ContentPartinopenai.rsrequirestext: String, so serde deserialization fails withdata did not match any variant of untagged enum DeltaContent.Fix
ContentPart.textoptional (String→Option<String>with#[serde(default)])extract_content_and_signatureto usefilter_map+as_deref()for the now-optional textReasoning content parts are already filtered out by the existing
filter(|p| p.r#type == "text"), so they don't affect text extraction. Reasoning is captured separately viaDelta.reasoning_content/Delta.reasoning_details.Fixes #8077