Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Reland "Cros: Report metrics for the animation of traslucent background"
This reverts commit 9fcd754. Reason for revert: breaks compile (bad merge) Original change's description: > Revert "Cros: Report metrics for the animation of traslucent background" > > This reverts commit 64465df. > > Reason for revert: Speculative revert to fix use-of-uninitialized member flake / crash; see https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8886180914914709040/+/steps/browser_tests/0/logs/Deterministic_failure:_PublicSessionOobeTestImpl__x2f_PublicSessionOobeTest.NoTermsOfService__x2f_4__status_CRASH_/0 > > ==18002==WARNING: MemorySanitizer: use-of-uninitialized-value > #0 0x5640af44e1e6 in ui::AnimationMetricsRecorder::OnAnimationEnd(base::Optional<int>, float) ./../../ui/compositor/animation_metrics_recorder.cc:64:14 > #1 0x5640af4e4b37 in ui::LayerAnimationElement::ProgressToEnd(ui::LayerAnimationDelegate*) ./../../ui/compositor/layer_animation_element.cc:669:34 > #2 0x5640af4fbb95 in ui::LayerAnimationSequence::ProgressToEnd(ui::LayerAnimationDelegate*) ./../../ui/compositor/layer_animation_sequence.cc:147:35 > #3 0x5640af513c54 in ProgressAnimationToEnd ./../../ui/compositor/layer_animator.cc:476:13 > #4 0x5640af513c54 in ui::LayerAnimator::FinishAnimation(ui::LayerAnimationSequence*, bool) ./../../ui/compositor/layer_animator.cc:622:5 > #5 0x5640af519c6d in ui::LayerAnimator::StopAnimatingInternal(bool) ./../../ui/compositor/layer_animator.cc:533:5 > #6 0x5640af489c93 in StopAnimating ./../../ui/compositor/layer_animator.h:198:26 > #7 0x5640af489c93 in ui::Layer::CompleteAllAnimations() ./../../ui/compositor/layer.cc:1128:12 > #8 0x5640af3c6ff1 in aura::Window::~Window() ./../../ui/aura/window.cc:124:14 > #9 0x5640af3ca7ac in aura::Window::~Window() ./../../ui/aura/window.cc:119:19 > #10 0x5640a9a51655 in views::NativeWidgetAura::~NativeWidgetAura() ./../../ui/views/widget/native_widget_aura.cc:0:0 > #11 0x5640a9a51b9c in views::NativeWidgetAura::~NativeWidgetAura() ./../../ui/views/widget/native_widget_aura.cc:1054:39 > #12 0x5640a99ba714 in views::Widget::~Widget() ./../../ui/views/widget/widget.cc:185:5 > #13 0x5640b72c7e39 in ash::HotseatWidget::~HotseatWidget() ./../../ash/shelf/hotseat_widget.cc:354:1 > #14 0x5640b72c7f9c in ash::HotseatWidget::~HotseatWidget() ./../../ash/shelf/hotseat_widget.cc:350:33 > #15 0x5640b7319b53 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5 > #16 0x5640b7319b53 in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7 > #17 0x5640b7319b53 in ash::Shelf::ShutdownShelfWidget() ./../../ash/shelf/shelf.cc:377:19 > #18 0x5640b724c95f in ash::RootWindowController::CloseChildWindows() ./../../ash/root_window_controller.cc:659:11 > #19 0x5640b741f9c5 in ash::Shell::CloseAllRootWindowChildWindows() ./../../ash/shell.cc:1269:19 > #20 0x5640b741532a in ash::Shell::~Shell() ./../../ash/shell.cc:720:3 > #21 0x5640b741fd3c in ash::Shell::~Shell() ./../../ash/shell.cc:589:17 > #22 0x5640b9be4d75 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5 > #23 0x5640b9be4d75 in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7 > #24 0x5640b9be4d75 in ChromeBrowserMainExtraPartsAsh::PostMainMessageLoopRun() ./../../chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.cc:245:19 > #25 0x5640a5abe85d in ChromeBrowserMainParts::PostMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1721:29 > #26 0x564094a9d525 in chromeos::ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:1136:32 > #27 0x56409b175e3f in content::BrowserMainLoop::ShutdownThreadsAndCleanUp() ./../../content/browser/browser_main_loop.cc:1095:13 > #28 0x56409b17ea9a in content::BrowserMainRunnerImpl::Shutdown() ./../../content/browser/browser_main_runner_impl.cc:178:17 > #29 0x56409b165bd4 in content::BrowserMain(content::MainFunctionParams const&) ./../../content/browser/browser_main.cc:49:16 > #30 0x5640a3b3284b in RunBrowserProcessMain ./../../content/app/content_main_runner_impl.cc:529:10 > #31 0x5640a3b3284b in content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) ./../../content/app/content_main_runner_impl.cc:978:10 > #32 0x5640a3b311b2 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:878:12 > #33 0x5640b1028f28 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:455:29 > #34 0x56409f705fd0 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10 > #35 0x5640a762696a in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:513:3 > chromium#36 0x5640a53fb49d in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:299:20 > #37 0x5640960c6b50 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 > #38 0x5640960c6b50 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2663:3 > chromium#39 0x5640960cb24d in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2845:11 > #40 0x5640960cd5f9 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2977:28 > #41 0x564096106f6e in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5518:44 > chromium#42 0x5640961053fd in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest-internal-inl.h:0:10 > #43 0x5640961053fd in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5105:10 > #44 0x5640a5902835 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2472:46 > #45 0x5640a5902835 in base::TestSuite::Run() ./../../base/test/test_suite.cc:458:16 > #46 0x5640a5393dd1 in BrowserTestSuiteRunnerChromeOS::RunTestSuite(int, char**) ./../../chrome/test/base/browser_tests_main_chromeos.cc:37:23 > #47 0x5640a773a27e in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:375:31 > #48 0x5640a5394f45 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:246:10 > #49 0x5640a5393bb8 in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:52:10 > #50 0x7f194b36282f in __libc_start_main /build/glibc-LK5gWL/glibc-2.23/csu/../csu/libc-start.c:291:0 > #51 0x56408b4293c9 in _start ??:0:0 > > Uninitialized value was created by a heap deallocation > #0 0x56408b497790 in operator delete(void*) /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/msan/msan_new_delete.cpp:74:44 > #1 0x5640b72c7d74 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5 > #2 0x5640b72c7d74 in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7 > #3 0x5640b72c7d74 in ~unique_ptr ./../../buildtools/third_party/libc++/trunk/include/memory:2587:19 > #4 0x5640b72c7d74 in ash::HotseatWidget::~HotseatWidget() ./../../ash/shelf/hotseat_widget.cc:354:1 > #5 0x5640b72c7f9c in ash::HotseatWidget::~HotseatWidget() ./../../ash/shelf/hotseat_widget.cc:350:33 > #6 0x5640b7319b53 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5 > #7 0x5640b7319b53 in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7 > #8 0x5640b7319b53 in ash::Shelf::ShutdownShelfWidget() ./../../ash/shelf/shelf.cc:377:19 > #9 0x5640b724c95f in ash::RootWindowController::CloseChildWindows() ./../../ash/root_window_controller.cc:659:11 > #10 0x5640b741f9c5 in ash::Shell::CloseAllRootWindowChildWindows() ./../../ash/shell.cc:1269:19 > #11 0x5640b741532a in ash::Shell::~Shell() ./../../ash/shell.cc:720:3 > #12 0x5640b741fd3c in ash::Shell::~Shell() ./../../ash/shell.cc:589:17 > #13 0x5640b9be4d75 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5 > #14 0x5640b9be4d75 in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7 > #15 0x5640b9be4d75 in ChromeBrowserMainExtraPartsAsh::PostMainMessageLoopRun() ./../../chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.cc:245:19 > #16 0x5640a5abe85d in ChromeBrowserMainParts::PostMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1721:29 > #17 0x564094a9d525 in chromeos::ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:1136:32 > #18 0x56409b175e3f in content::BrowserMainLoop::ShutdownThreadsAndCleanUp() ./../../content/browser/browser_main_loop.cc:1095:13 > #19 0x56409b17ea9a in content::BrowserMainRunnerImpl::Shutdown() ./../../content/browser/browser_main_runner_impl.cc:178:17 > #20 0x56409b165bd4 in content::BrowserMain(content::MainFunctionParams const&) ./../../content/browser/browser_main.cc:49:16 > #21 0x5640a3b3284b in RunBrowserProcessMain ./../../content/app/content_main_runner_impl.cc:529:10 > #22 0x5640a3b3284b in content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) ./../../content/app/content_main_runner_impl.cc:978:10 > #23 0x5640a3b311b2 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:878:12 > #24 0x5640b1028f28 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:455:29 > #25 0x56409f705fd0 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10 > #26 0x5640a762696a in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:513:3 > #27 0x5640a53fb49d in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:299:20 > > Original change's description: > > Cros: Report metrics for the animation of traslucent background > > > > This animation happens during transition between hotseat states. > > > > Bug: 1058609 > > Change-Id: Iff1f81625e6de2bf6dc6dcfee09225c4d16cc53e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088641 > > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > > Reviewed-by: Manu Cornet <manucornet@chromium.org> > > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > > Commit-Queue: Ana Salazar <anasalazar@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#748806} > > TBR=rkaplow@chromium.org,newcomer@chromium.org,manucornet@chromium.org,anasalazar@chromium.org > > Change-Id: I28dfaa49cae6e27801975a2863c013b9f9a5edca > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1058609 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097507 > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Commit-Queue: Joshua Pawlicki <waffles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#749146} TBR=rkaplow@chromium.org,waffles@chromium.org,newcomer@chromium.org,manucornet@chromium.org,anasalazar@chromium.org Change-Id: I9eb448a6d4ea88624c9535a30cdfa519fc431d50 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1058609 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097508 Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#749151}
- Loading branch information