frontend: Discard tray MAVLink listeners on destroy - #4033
Closed
joaoantoniocardoso wants to merge 1 commit into
Closed
frontend: Discard tray MAVLink listeners on destroy#4033joaoantoniocardoso wants to merge 1 commit into
joaoantoniocardoso wants to merge 1 commit into
Conversation
Store HEARTBEAT/GPS listeners with markRaw and discard them in beforeDestroy so remounts do not stack callbacks on shared endpoints.
Automated PR Review0. Summary
Cleans up MAVLink listeners for the Health and GPS tray menus by storing them (wrapped in No further comments, nice job 👍 Generated by PR Review Bot. This is advisory, a human reviewer must still approve. |
joaoantoniocardoso
marked this pull request as draft
July 25, 2026 15:51
joaoantoniocardoso
marked this pull request as ready for review
July 25, 2026 15:51
3 tasks
Member
Author
|
Superseded by #4046 (same changes, head moved to fork |
Member
Author
|
Closed in favor of #4046. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
markRawanddiscard()ed inbeforeDestroy.Endpoint.latestDataevery frame).Test plan