You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Straightforward backport of #4051 to 1.4-dev: wraps the PortWatcher.start_watching polling body in a try/except Exception so a transient failure (e.g. KeyError from a network interface disappearing between psutil.net_if_stats/net_if_addrs snapshots in add_ping360) no longer kills the watcher task. Adds a targeted pytest-asyncio regression test and pulls the psutil == 5.7.2 dependency into core/services/ping/setup.py and the root pyproject.toml dev-deps (already used transitively by ping360_ethernet_prober.py and pingutils.py). asyncio.CancelledError is a BaseException in 3.11 so it still propagates and cancellation semantics are preserved — the test correctly asserts this.
No further comments, nice job 👍
Generated by PR Review Bot. This is advisory, a human reviewer must still approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of #4051 into 1.4.
Supersedes #4042 (recreated from fork
joaoantoniocardoso/BlueOS-dockerinstead of same-repo head).