You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adds a post-compression Vite plugin (validate-emitted-javascript) that recursively walks dist/, gunzips each .js/.js.gz chunk, and runs esbuild.transformSync on it — so a corrupt emitted chunk (like the source-map-as-chunk regression in 1.4.4-beta.14) fails the build instead of only breaking the route that imports it at runtime. enforce: 'post' plus closeBundle: { sequential: true } correctly orders it after viteCompression, so it validates the exact bytes nginx serves via gzip_static. esbuild is a transitive dep of Vite so require('esbuild') resolves reliably; the regex /\.js(\.gz)?$/ correctly ignores .js.map sourcemaps (which aren't in the compression filter and remain as-is on disk) and doesn't accidentally match .mjs/.cjs. Comment style explains the "why" without parroting, and the change follows the existing CommonJS require() pattern already used in this file.
No further comments, nice job 👍
Generated by PR Review Bot. This is advisory, a human reviewer must still approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the fix for #4091 from #4094 (1.4) into master.