Skip to content

Strengthen seqNo lock regression test#248

Merged
zfields merged 1 commit into
blues:masterfrom
zakoverflow:zak/fix-seqno-unlock-regression-test
Jul 2, 2026
Merged

Strengthen seqNo lock regression test#248
zfields merged 1 commit into
blues:masterfrom
zakoverflow:zak/fix-seqno-unlock-regression-test

Conversation

@zakoverflow

Copy link
Copy Markdown
Contributor

Summary

  • replace the CRC-stamping lock regression check with one that verifies seqNo advances before the Notecard unlock hook returns
  • start a nested unlocked transaction from the unlock hook and assert it sees firstSeq + 1, which would fail if seqNo++ moved after unlock

Testing

  • docker run --rm -v /home/ubuntu/.openclaw/workspace/note-c:/note-c -w /note-c ghcr.io/blues/note_c_ci:latest bash -lc 'cmake --build build --target NoteTransaction_test -j && ./build/test/NoteTransaction_test && ctest --test-dir build --output-on-failure'\n- 166/166 unit tests passed\n\n## Architecture docs\n- No architecture doc update needed; this is test-only coverage for the existing locking behavior.

@zfields zfields merged commit ee7e7ed into blues:master Jul 2, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants