Better handling of blocks in KnownFollowers
#4563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4563.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cpouhu56l47c73estl40. |
|
gaearon
reviewed
Jun 18, 2024
gaearon
approved these changes
Jun 18, 2024
estrattonbailey
added a commit
that referenced
this pull request
Jun 20, 2024
* origin/main: (62 commits) Rework "Who can reply" to blend more nicely into the UI (#4578) Fix threadgate read after write (#4577) Convert button to use forwardRef (#4576) use 1000x1000 for image height in avatar cropper (#4453) fix for autofill covering border (#4573) Update HomeHeaderLayoutMobile.tsx (#4572) Option for large alt badges (#4571) Truncate post metrics and fix truncation on native (#4575) Fix avi placeholder layout (#4570) add support for `ListEmptyComponent`, allow `undefined` data (#4403) GIF previews in notifications (#4447) [Session] Convert account to session data explicitly (#4446) Move onboarding start to after successfull account creation (#4381) Collection of moderation fixes (#4566) Fix undefined block (#4479) fix gap between tab bar and its border (#4538) Better handling of blocks in `KnownFollowers` (#4563) Verify email reminders (#4510) Bump labeler limit to 20 (#4565) Migrate local thread mutes (#4523) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So the issue here is that there are two count values that matter,
lengthorcount:knownFollowers.followers.lengthknownFollowers.countfollowers[]filters out blocks, and only hydrates 5 profiles server-side, so that array could be0, though it's unlikely. If that ever happened, we'd just not render anything at all.More likely is
followers.length < countbecause 1 or more profiles are blocked and filtered out.So rendering should be driven by
followers.length, butand N otherscan only be driven bycountsince that can be much higher than the 5 max returned onfollowers.So the fix here is:
followers[]to rendercountto determine if we need a,orandcountto determine if we needand N othersHere's a test case illustrating that: we have 3 follows in common, but I block one of them. Note only 2 avis (one is blocked), but it still says
and 1 other. Clicking through will only show 2 profiles.