Verify email reminders #4510
Merged
Verify email reminders #4510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4510.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cplkbiuehbks73fusni0. |
|
gaearon
reviewed
Jun 18, 2024
gaearon
reviewed
Jun 18, 2024
gaearon
requested changes
Jun 18, 2024
There was a problem hiding this comment.
Noted a potential bug in Safari stemming from custom string representation. It's possible to fix by padding with zeroes but IMO would be more sturdy if we relied on standard stringify/parse (so just built-in methods like ISO stringify/parse) and then explicitly compared year/month/date between two Date objects. How do you feel about that?
* origin/main: (35 commits) Bump labeler limit to 20 (#4565) Migrate local thread mutes (#4523) Disable newskie dialog tap in hover card web (#4562) Implement thread locking (#4545) Prevent unecessary calls (#4561) Force callers of `getTimeAgo` to pass in the value for "now" (#4560) Fix: only apply self-thread load-more behavior on the outer edge of the reply tree (#4559) Server-side thread mutes (#4518) Explore fixes (#4540) Is it "newskie" or "newsky" 🤔 (#4557) fix keyboard overlaying onboarding inputs (#4558) Add `useGetTimeAgo` and utils (#4556) Unconditionally polyfill Intl.PluralRules for native (#4554) Dedupe Zod installation (#4551) Use exact imports for icons (#4549) Fix Android startup perf regression (#4544) Explore feed cards (#4521) Onboarding fixes (#4508) Add `native_pwi_disabled` feature gate experiment (#4507) Select, don't mutate (#4541) ...
gaearon
approved these changes
Jun 18, 2024
estrattonbailey
added a commit
that referenced
this pull request
Jun 20, 2024
* origin/main: (62 commits) Rework "Who can reply" to blend more nicely into the UI (#4578) Fix threadgate read after write (#4577) Convert button to use forwardRef (#4576) use 1000x1000 for image height in avatar cropper (#4453) fix for autofill covering border (#4573) Update HomeHeaderLayoutMobile.tsx (#4572) Option for large alt badges (#4571) Truncate post metrics and fix truncation on native (#4575) Fix avi placeholder layout (#4570) add support for `ListEmptyComponent`, allow `undefined` data (#4403) GIF previews in notifications (#4447) [Session] Convert account to session data explicitly (#4446) Move onboarding start to after successfull account creation (#4381) Collection of moderation fixes (#4566) Fix undefined block (#4479) fix gap between tab bar and its border (#4538) Better handling of blocks in `KnownFollowers` (#4563) Verify email reminders (#4510) Bump labeler limit to 20 (#4565) Migrate local thread mutes (#4523) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the email verification reminder period to once per day, which is up from once all-time.
It does this by storing a date string with to-the-day resolution so that each date can be compared directly e.g.
'2024-6-13' === '2024-6-13'. If the reminder needs to be shown, it returnstrueand snoozes, which sets the stored string to the current date.As existing, once
account.emailConfirmedis true, this process stops entirely.Additionally, this PR snoozes the confirm check immediately upon account creation, so that users aren't prompted to verify until 1 calendar date later.