Skip to content

Make sure currentlocale on edit is always set#1530

Merged
bobdenotter merged 6 commits intomasterfrom
bugfix/currentlocale-always-set
Jun 22, 2020
Merged

Make sure currentlocale on edit is always set#1530
bobdenotter merged 6 commits intomasterfrom
bugfix/currentlocale-always-set

Conversation

@I-Valchev
Copy link
Copy Markdown
Member

Fixes #1528

Comment thread src/Controller/Backend/ContentEditController.php
@I-Valchev
Copy link
Copy Markdown
Member Author

I-Valchev commented Jun 22, 2020

@bobdenotter Also had to change _localeswitcher.html.twig since after this change currentlocale is always defined, hence the switcher is always shown. I'm a bit unsure about this though: a CT could exist with just one locale that is different to the default one, but that won't be visible in the admin panel with this latest change.

I can think of 3 possible solutions:

  • always show the locale switcher (even if just 1 option exists)
  • never show the locale switcher when just 1 option exists
  • show the locale switcher when one option exists only if that option is different than the default site locale

What do you think?

@bobdenotter bobdenotter merged commit 2af9917 into master Jun 22, 2020
@I-Valchev I-Valchev deleted the bugfix/currentlocale-always-set branch June 22, 2020 14:30
@bobdenotter bobdenotter changed the title Make sure currentlocale on edit is always set Make sure currentlocale on edit is always set Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

View saved version button does not work on homepage or singletons

2 participants