Skip to content

Collapsible collections#1830

Merged
bobdenotter merged 16 commits intomasterfrom
feature/collapsible-collections
Sep 10, 2020
Merged

Collapsible collections#1830
bobdenotter merged 16 commits intomasterfrom
feature/collapsible-collections

Conversation

@I-Valchev
Copy link
Copy Markdown
Member

@I-Valchev I-Valchev commented Sep 4, 2020

image

image

@I-Valchev I-Valchev changed the title [WIP] Collapsible collections Collapsible collections Sep 8, 2020
@bobdenotter
Copy link
Copy Markdown
Member

Looks good so far! Were you planning on modifying the "Add" menu to be a bit more like it was in Bolt 3?

Here's an example I found on one of our sites (NTS):

Schermafbeelding 2020-09-08 om 10 44 58

@I-Valchev
Copy link
Copy Markdown
Member Author

@bobdenotter yes I tried that but there's an issue with the multi-select tool we us. Its docs say that you can listen to the select event when something is clicked (hence when we add a new item), but in reality that only works like onchange. That doesn't work for us.

I'm creating an issue for it here shentao/vue-multiselect#1324

@bobdenotter
Copy link
Copy Markdown
Member

bobdenotter commented Sep 8, 2020

Maybe it shouldn't be a Vue-select thingy, but just a simple dropdown button:

(that makes it easy to include the icons, too)

https://getbootstrap.com/docs/4.0/components/dropdowns/

@eduardomart
Copy link
Copy Markdown
Contributor

May I suggest an option for showing icons only? as opposed to icon and label on each button for move/up/down/delete :-)

@I-Valchev
Copy link
Copy Markdown
Member Author

@eduardomart I think that's one of the things that advanced users of Bolt are going to appreciate (less crowded interface, more space), but for people starting out with the CMS there's a high chance it won't be clear what those buttons are for.

Right now, let's merge this in as is and think about improving it further still!

Copy link
Copy Markdown
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoop whoop!

@bobdenotter bobdenotter merged commit b5201aa into master Sep 10, 2020
@bobdenotter bobdenotter deleted the feature/collapsible-collections branch September 10, 2020 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants