Skip to content

Update hidden.html.twig#1880

Merged
bobdenotter merged 1 commit intobolt:masterfrom
eduardomart:patch-3
Sep 21, 2020
Merged

Update hidden.html.twig#1880
bobdenotter merged 1 commit intobolt:masterfrom
eduardomart:patch-3

Conversation

@eduardomart
Copy link
Copy Markdown
Contributor

  • Fixes typo in pattern
  • Adds prefix/postfix

- Fixes typo in pattern
- Adds prefix/postfix
Copy link
Copy Markdown
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll merge this in for now. At some point in time we should re-evaluate how this field works though.. A "pattern" for a hidden field feels weird. It's not like the Editor has a chance of fixing it, if the input is incorrect, since they (by design) can't see or interact with the Field.

I think ideally the hidden field should be hidden with no output, and we'll make another way to add descriptions or other small blurbs in the editor in a different way.

@bobdenotter bobdenotter merged commit 76744d2 into bolt:master Sep 21, 2020
@bobdenotter bobdenotter changed the title Update hidden.html.twig Update hidden.html.twig Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants