Merged
Conversation
Contributor
eduardomart
commented
Sep 21, 2020
- Fixes typo in pattern
- Adds prefix/postfix
- Fixes typo in pattern - Adds prefix/postfix
bobdenotter
approved these changes
Sep 21, 2020
Member
bobdenotter
left a comment
There was a problem hiding this comment.
Thanks! I'll merge this in for now. At some point in time we should re-evaluate how this field works though.. A "pattern" for a hidden field feels weird. It's not like the Editor has a chance of fixing it, if the input is incorrect, since they (by design) can't see or interact with the Field.
I think ideally the hidden field should be hidden with no output, and we'll make another way to add descriptions or other small blurbs in the editor in a different way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.