Skip to content

Fix iffy details/summary marker #1882

Merged
I-Valchev merged 5 commits intomasterfrom
eduardomart-patch-4
Sep 22, 2020
Merged

Fix iffy details/summary marker #1882
I-Valchev merged 5 commits intomasterfrom
eduardomart-patch-4

Conversation

@bobdenotter
Copy link
Copy Markdown
Member

@bobdenotter bobdenotter commented Sep 21, 2020

See #1881

What it looks like in Safari now:

Schermafbeelding 2020-09-21 om 14 18 49

eduardomart and others added 4 commits September 21, 2020 01:40
Please also add the following CSS:

```
.collection-item details summary::-webkit-details-marker {
    display: none;
}

.collection-item details summary i.card-marker-caret {
    margin-right: 0.75rem;
}

.collection-item details[open] summary i.card-marker-caret {
    transform: rotate(90deg);
}
```

And remove these CSS rules: 
```
.collection-container .collection-item details[open] summary::before {
    content: "▼";
}
.collection-container .collection-item details[open] summary::before {
    content: "▼";
    vertical-align: 25%;
    margin-right: .5rem;
    width: 15px;
    display: inline-block;
}
```
Also adds a line break between the label and button for  'Add new Set' at the end of a collection
Copy link
Copy Markdown
Member

@I-Valchev I-Valchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍 yes please! fantastic work @bobdenotter and @eduardomart !

@I-Valchev I-Valchev merged commit 00e2b3e into master Sep 22, 2020
@I-Valchev I-Valchev deleted the eduardomart-patch-4 branch September 22, 2020 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants