[composer] decouple post-install/update-cmd and skip run on CI#1961
Merged
bobdenotter merged 2 commits intobolt:masterfrom Oct 8, 2020
Merged
[composer] decouple post-install/update-cmd and skip run on CI#1961bobdenotter merged 2 commits intobolt:masterfrom
post-install/update-cmd and skip run on CI#1961bobdenotter merged 2 commits intobolt:masterfrom
Conversation
TomasVotruba
force-pushed
the
tv-ci-only-skip-scripts
branch
3 times, most recently
from
b4a3135 to
afdfdfe
Compare
TomasVotruba
force-pushed
the
tv-ci-only-skip-scripts
branch
from
afdfdfe to
0e651a1
Compare
Contributor
Author
|
Ready to merge 👍 Could someone verify this branch |
bobdenotter
approved these changes
Oct 8, 2020
Member
bobdenotter
left a comment
bobdenotter
left a comment
There was a problem hiding this comment.
Could someone verify this branch composer install work correctly for all the user-experience setup?
I've monkey-tested this on my setups, and it works fine! 👍
bobdenotter
added
the
topic: DX
bobdenotter
changed the title
post-install/update-cmd and skip run on CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementing #1918 (comment)