Fix homepage link generation, generate fallbacks as relative unless canonical#2207
Merged
SvanteRichter merged 1 commit intomasterfrom Dec 2, 2020
Merged
Conversation
Member
|
And merged into 4.1 too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue I had where the current locale was not picked up by homepage link generation.
Along the way I noticed that the fallback link generation ("Just use the current URL") always generated canonical links which sometimes led to links like "https://domain.tld/https://domain.tld" because it is used as a argument to setPath in getLink.